[Xamarin.Android.Cecil] fix assembly names if using $(CecilSourceDirectory) #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory) Context: dotnet/android#1747 Downstream in xamarin-android, I started getting a build failure on Windows such as: xamarin-android\external\Java.Interop\src\Xamarin.Android.Cecil\Xamarin.Android.Cecil.targets(23,5): error MSB3375: The file "..\..\bin\Debug\\Xamarin.Android.Cecil.dll" does not exist. xamarin-android\external\Java.Interop\src\Xamarin.Android.Cecil\Xamarin.Android.Cecil.targets(23,5): error MSB3375: The file "..\..\bin\Debug\\Xamarin.Android.Cecil.Mdb.dll" does not exist. Looking in my `external\Java.Interop\bin\Debug` directory, the `Mono.Cecil` assemblies were named `Mono.Cecil.*` instead of `Xamarin.Android.*`. I think this was an oversight, but I don't know how the builds were green... Looking at `Mono.Cecil.csproj` in `xamarin-android/external/mono/external/cecil` there was no way to override `AssemblyName`. But we can use the `<Move />` task instead. To fix this: - Added a `_MonoCecilAssemblies` to check for any files named `Mono.Cecil.*` - `<Move />` the files to start with `Xamarin.Android.*` instead.
Contributor
|
The fix lies in xamarin-android, and I'm sorry I didn't fix it at the same time. This code: dotnet/android@9bc51ae#diff-b67911656ef5d18c4ae36cb6741b7965R114 prepare-props: prepare-deps
+ cp $(call GetPath,JavaInterop)/external/Mono.Cecil* "$(call GetPath,MonoSource)/external"
+ cp "$(call GetPath,JavaInterop)/product.snk" "$(call GetPath,MonoSource)"Needs to be done within Windows/MSBuild as well, not just in the Makefile. It's the above two lines which causes the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#1747
Downstream in xamarin-android, I started getting a build failure on
Windows such as:
Looking in my
external\Java.Interop\bin\Debugdirectory, theMono.Cecilassemblies were namedMono.Cecil.*instead ofXamarin.Android.*.I think this was an oversight, but I don't know how the builds were
green...
Looking at
Mono.Cecil.csprojinxamarin-android/external/mono/external/cecilthere was no way tooverride
AssemblyName. But we can use the<Move />task instead.To fix this:
_MonoCecilAssembliesto check for any files namedMono.Cecil.*<Move />the files to start withXamarin.Android.*instead.