[generator] Mark Kotlin-mangled methods as non-virtual (#534) #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Dec 10, 2019
Fixes: #534 There are cases where Kotlin generates Java methods that are invalid Java identifiers: // Kotlin public open abstract class AbstractUnsigned { public open fun foo(value : UInt) { return 3u } } Results in Java bytecode: public abstract class example.AbstractUnsigned { public abstract void foo-WZ4Q5Ns(int); public example.AbstractUnsigned(); } `foo-WZ4Q5Ns` is not a valid Java identifier, due to the `-`. We already change the name to `Foo()` so C# can compile the method, and JNI allows us to call the method correctly. However we cannot allow the user to override this method because we cannot create the Java override in the JCW. In this case, mark the method as *non*-`virtual` to prevent the user from overriding it: // C# partial class AbstractUnsigned { public void Foo(int value) …} }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where Kotlin generates Java methods that are not allowed Java identifier names:
We already change the name to
Foo ()so C# can compile the method, and JNI allows us to call the method correctly. However we cannot allow the user to override this method because we cannot create the Java override in the JCW.Virtual Method
In this case we need to mark the method as non-virtual to prevent the user from overriding it.