[JCW] Throw error if user tries to override a Kotlin name-mangled method. (#534) #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
javastubs-kotlin-error
branch
from
59a944a to
7df96af
Compare
jpobst
force-pushed
the
javastubs-kotlin-error
branch
from
7df96af to
20417e5
Compare
jonpryor
pushed a commit
that referenced
this pull request
Dec 12, 2019
…537) Context: #534 Context: #535 Context: 0065de4 There are cases where Kotlin generates Java methods that are not valid Java identifiers: // `javap` output for a Kotlin type using UInt parameters public abstract class Bar { abstract void foo-WZ4Q5Ns(int); } public interface IBar { void foo-WZ4Q5Ns(int); } In this case we cannot allow the user to inherit from the class or implement the interface as the mangled method cannot be present within Java Callable Wrapper source code. We still need the class to be bound because there might be a Kotlin- created subclass that needs the base class to exist. There's no foolproof way to mark these as "not implementable". The best we can do for now is to detect if the user implements them in the `<GenerateJavaStubs/>` task / `JavaCallableWrapperGenerator` and give an informative error at that point. Update `JavaCallableWrapperGenerator` so that when a Kotlin-generated mangled method name is encountered, an XA4213 error is emitted: error XA4213: Cannot override Kotlin-generated method 'foo-WZ4Q5Ns' because it is not a valid Java method name. This method can only be overridden from Kotlin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #534
There are cases where Kotlin generates Java methods that are not allowed Java identifier names:
In this case we cannot allow the user to implement the class as the mangled method cannot be implemented. We still need the class to be bound because there might be a Kotlin-created subclass
that needs the base class to exist.
There's no foolproof way to mark these as "not implementable". The best we can do for now is to detect if the user implements them in
GenerateJavaStubsand give an informative error at that point.This PR adds this error: