[tests] Convert to Unix style line endings #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android@130905e Context: https://github.com/xamarin/QualityAssurance/pull/3478 We've recently started running `Java.Interop` tests on an Android target as part of the `Mono.Android-Tests` suite. This has introduced some seemingly harmless failures[0] when building this suite on Windows and then running it on Android. We can fix this by converting line endings before comparing strings. [0]: 01-02 16:18:11.949 I/NUnit (23743): Failed tests: 01-02 16:18:11.949 I/NUnit (23743): 1) Java.InteropTests.JniValueMarshaler_Boolean_ContractTests.JniValueMarshalerContractTests`1.CreateReturnValueFromManagedExpression (Java.Interop-Tests) 01-02 16:18:11.949 I/NUnit (23743): Expected string length 111 but was 99. Strings differ at index 1. 01-02 16:18:11.949 I/NUnit (23743): Expected: "{\r\n\tJniRuntime __jvm;\r\n\tbool __value;\r\n\r\n\ttry\r\n\t{\r\n\t\treturn _..." 01-02 16:18:11.949 I/NUnit (23743): But was: "{\n\tJniRuntime __jvm;\n\tbool __value;\n\n\ttry\n\t{\n\t\treturn __value..." 01-02 16:18:11.949 I/NUnit (23743): -------------^ 01-02 16:18:11.949 I/NUnit (23743): 01-02 16:18:11.949 I/NUnit (23743): at Java.InteropTests.JniValueMarshalerContractTests`1[T].CheckExpression (Java.Interop.Expressions.JniValueMarshalerContext context, System.String expected, System.Linq.Expressions.Expression ret) [0x00083] in <59a94475f2544934836dac1b5c1cf1e1>:0 01-02 16:18:11.949 I/NUnit (23743): 2) Java.InteropTests.JniValueMarshaler_Char_ContractTests.JniValueMarshalerContractTests`1.CreateReturnValueFromManagedExpression (Java.Interop-Tests) 01-02 16:18:11.949 I/NUnit (23743): Expected string length 111 but was 99. Strings differ at index 1. 01-02 16:18:11.949 I/NUnit (23743): Expected: "{\r\n\tJniRuntime __jvm;\r\n\tchar __value;\r\n\r\n\ttry\r\n\t{\r\n\t\treturn _..." 01-02 16:18:11.949 I/NUnit (23743): But was: "{\n\tJniRuntime __jvm;\n\tchar __value;\n\n\ttry\n\t{\n\t\treturn __value..." 01-02 16:18:11.949 I/NUnit (23743): -------------^ 01-02 16:18:11.949 I/NUnit (23743): 01-02 16:18:11.949 I/NUnit (23743): at Java.InteropTests.JniValueMarshalerContractTests`1[T].CheckExpression (Java.Interop.Expressions.JniValueMarshalerContext context, System.String expected, System.Linq.Expressions.Expression ret) [0x00083] in <59a94475f2544934836dac1b5c1cf1e1>:0
jpobst
approved these changes
Jan 3, 2020
Member
Author
|
This is working for me locally: |
jonathanpeppers
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android@130905e
Context: https://github.com/xamarin/QualityAssurance/pull/3478
We've recently started running
Java.Interoptests on an Android targetas part of the
Mono.Android-Testssuite. This has introduced someseemingly harmless failures[0] when building this suite on Windows and
then running it on Android. We can fix this by converting line endings
before comparing strings.
[0]: