[generator] Make DIM invoking plumbing private. #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Feb 24, 2020
Context: #509 We have never used explicit `private` modifiers on class members due to the [Mono Coding Guidelines][0], as `private` is the default. However, when working with Default Interface Methods on interfaces members, the default is `public`. This results in our plumbing members like `_members` and `static Delegate cb_DoSomething;` being exposed as part of the interface's public API. This commit makes private interface members explicitly `private`. [0]: https://www.mono-project.com/community/contributing/coding-guidelines/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #509.
We have never used explicit
privatemodifiers on class members due to the Mono Coding Guidelines, asprivateis the default. However, when working with DIM on interfaces members, the default ispublic. This results in our plumbing members like_membersandstatic Delegate cb_DoSomething;being exposed as part of the interface's public API.This commit makes private interface members explicitly
private.