Skip to content

Conversation

@echesakov
Copy link
Contributor

No description provided.

@echesakov echesakov force-pushed the PublishBuildArtifacts branch from 8c85f9a to 9555d85 Compare May 21, 2019 22:27
@echesakov echesakov marked this pull request as ready for review May 21, 2019 22:30
@echesakov
Copy link
Contributor Author

@dotnet/jit-contrib PTAL

@echesakov
Copy link
Contributor Author

echesakov commented May 21, 2019

I am not sure whether we need to publish for each arch/os configuration or it would be good enough to publish binaries built targeting any RID

@sbomer
Copy link
Member

sbomer commented May 21, 2019

If you're only building managed code, I think the easiest thing to do is to publish framework-dependent, without passing a RID. That should be usable on any platform (as long as you already have a framework on the target machine - if I understand your scenario, it sounds like you'll be placing the built binaries into CORE_ROOT, which should work AFAIK). Just note that by default "dotnet publish" will still produce an apphost for the host platform - you just wouldn't use that.

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much experience understanding this format, but it seems ok to me.

@echesakov echesakov changed the title Add publishing step [WIP] Add publishing step May 28, 2019
@echesakov
Copy link
Contributor Author

Not going to work on this in near future.

@echesakov echesakov closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants