Onboarding onto Arcade #219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echesakov
force-pushed
the
OnboardingOntoArcade
branch
from
5ae9a5b to
b4ac620
Compare
sbomer
reviewed
Nov 1, 2019
| <SystemIOFileSystemPackageVersion>4.3.0</SystemIOFileSystemPackageVersion> | ||
| <SystemNetPrimitivesPackageVersion>4.3.0</SystemNetPrimitivesPackageVersion> | ||
| <runtimenativeSystemPackageVersion>4.3.0</runtimenativeSystemPackageVersion> | ||
| <SystemSecurityPrincipalPackageVersion>4.3.0</SystemSecurityPrincipalPackageVersion> |
Member
There was a problem hiding this comment.
Consider using Version instead of PackageVersion as a suffix - not that it really matters, but will be more consistent with dotnet/coreclr#27606 for example.
sbomer
approved these changes
Nov 1, 2019
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
LGTM. I'd make sure that the updated projects continue to work with the bootstrapping scripts if you haven't already.
Merged
Contributor
|
@echesakovMSFT - Are you planning to pursue this further? |
Contributor
Author
@kunalspathak Yes, but not earlier than I finish moving coredistools to a separate repo. |
29 tasks
Contributor
Author
|
Not going to work on this in near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.