Add support for crossgen2 to jit-dasm and jit-diff. #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dotnet/jit-contrib PTAL |
echesakov
reviewed
Nov 21, 2019
echesakov
reviewed
Nov 21, 2019
--crossgen arg can now point to crossgen.exe or crossgen2.exe. crossgen.exe and crossgen2.exe have diffferent command line args so jit-dasm takes care of passing the right args depending on whether --crossgen points to crossgen.exe or crossgen2.exe.
erozenfeld
force-pushed
the
Crossgen2Support
branch
from
84e69a5 to
551b556
Compare
Member
Author
|
I also changed command line list creation to use Add instead of Insert to make it linear instead of quadratic. |
jashook
approved these changes
Nov 21, 2019
erozenfeld
added a commit
to erozenfeld/jitutils
that referenced
this pull request
Nov 26, 2019
This is a follow-up to dotnet#228. Unlike crossgen.exe, crossgen2.exe needs an explicit --optimize option. I added the method to set it in dotnet#228 but forgot to call it from GenerateAsm. This change adds the missing call.
erozenfeld
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--crossgen arg can now point to crossgen.exe or crossgen2.exe.
crossgen.exe and crossgen2.exe have diffferent command line args
so jit-dasm takes care of passing the right args depending on whether
--crossgen points to crossgen.exe or crossgen2.exe.