Clean up clearinitlocals handling #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sbomer
commented
Jun 3, 2020
sbomer
commented
- Avoids changing assembly action
- Uses assembly optimizations instead of custom data
- Fixes Clean up ClearInitLocalsStep step #1129
sbomer
added a commit
to sbomer/runtime
that referenced
this pull request
Jun 3, 2020
See dotnet/linker#1237. Setting the boolean ClearInitLocals is sufficient here because we are only linking the target assembly. If in the future we need to control it per-assembly, we can use metadata on AssemblyPaths: https://github.com/mono/linker/blob/master/src/ILLink.Tasks/LinkTask.cs#L23
This was referenced Jun 3, 2020
Member
|
Do we need to keep supporting this now that dotnet/runtime#454 is part of .NET 5 (and the Roslyn feature is in Roslyn's master)? |
Member
Author
|
I think once dotnet/runtime#35527 is finished we can drop it. dotnet/runtime is the only place I know of that is using the optimization. |
marek-safar
reviewed
Jun 3, 2020
marek-safar
approved these changes
Jun 4, 2020
- Avoids changing assembly action - Uses assembly optimizations instead of custom data - Fixes dotnet#1129
Remove error message
sbomer
force-pushed
the
clearInitLocalsCleanup
branch
from
c6d65d3 to
964c99d
Compare
sbomer
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 4, 2020
See dotnet/linker#1237. Setting the boolean ClearInitLocals is sufficient here because we are only linking the target assembly. If in the future we need to control it per-assembly, we can use metadata on AssemblyPaths: https://github.com/mono/linker/blob/master/src/ILLink.Tasks/LinkTask.cs#L23
tkapin
pushed a commit
to tkapin/runtime
that referenced
this pull request
Jan 31, 2023
* Clean up clearinitlocals handling - Avoids changing assembly action - Uses assembly optimizations instead of custom data - Fixes dotnet/linker#1129 * PR feedback Remove error message Commit migrated from dotnet/linker@7e11c51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.