Renaming OptimizationTolerance to fix a spelling error. #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogancarr
requested review from
abgoswam,
shmoradims and
wschin
and removed request for
abgoswam and
wschin
wschin
approved these changes
Apr 4, 2019
Contributor
|
Just need to update the entrypoint catalog. |
TomFinley
reviewed
Apr 4, 2019
| { | ||
| MaximumNumberOfIterations = 100, | ||
| OptmizationTolerance = 1e-8f, | ||
| OptimizationTolerance = 1e-8f, |
Contributor
There was a problem hiding this comment.
So, this is desirable, but it is a breaking change, not sure what our procedure and thoughts are about that.
Contributor
Author
There was a problem hiding this comment.
I was going to see if we could Ask it into 1.0. I will ask.
Contributor
Author
There was a problem hiding this comment.
Process: Check into master: Cherry-pick into the release branch. PR into release branch will be part of ask-mode.
Codecov Report
@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
+ Coverage 72.6% 72.62% +0.02%
==========================================
Files 807 807
Lines 144957 145080 +123
Branches 16211 16213 +2
==========================================
+ Hits 105240 105365 +125
+ Misses 35298 35297 -1
+ Partials 4419 4418 -1
|
rogancarr
added a commit
to rogancarr/machinelearning
that referenced
this pull request
Apr 5, 2019
* Renaming OptimizationTolerance in LBFGS to fix a spelling bug. (cherry picked from commit 073a33b)
rogancarr
added a commit
to rogancarr/machinelearning
that referenced
this pull request
Apr 5, 2019
* Renaming OptimizationTolerance in LBFGS to fix a spelling bug. (cherry picked from commit 073a33b)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
LbfgsTrainerBase, theOptmizationToleranceoption was misspelled.Fixes #3198