Skip to content

Conversation

@zeahmed
Copy link
Contributor

@zeahmed zeahmed commented Apr 5, 2019

This PR is related to #3205.

It also makes all the inner input/output classes to private.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #3222 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
+ Coverage   72.61%   72.61%   +<.01%     
==========================================
  Files         807      807              
  Lines      145077   145077              
  Branches    16213    16213              
==========================================
+ Hits       105346   105353       +7     
+ Misses      35315    35309       -6     
+ Partials     4416     4415       -1
Flag Coverage Δ
#Debug 72.61% <ø> (ø) ⬆️
#production 68.16% <ø> (ø) ⬆️
#test 88.93% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 74.03% <0%> (+0.33%) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 88.43% <0%> (+0.9%) ⬆️

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@zeahmed zeahmed merged commit fc89745 into dotnet:master Apr 5, 2019
zeahmed added a commit to zeahmed/machinelearning that referenced this pull request Apr 8, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants