Skip to content

remove unused files. #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfilipi merged 1 commit into from
Apr 5, 2019
Merged

remove unused files. #3223

sfilipi merged 1 commit into from
Apr 5, 2019

Conversation

@sfilipi
Copy link
Member

@sfilipi sfilipi commented Apr 5, 2019

Fixes #502 by removing the unused files with gplv2 license.

@sfilipi sfilipi requested review from eerhardt, glebuk and shauheen April 5, 2019 20:42
@sfilipi sfilipi self-assigned this Apr 5, 2019
Ivanidzo4ka
Ivanidzo4ka approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Apr 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7e0cc46). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3223   +/-   ##
=========================================
  Coverage          ?   72.62%           
=========================================
  Files             ?      807           
  Lines             ?   145080           
  Branches          ?    16213           
=========================================
  Hits              ?   105367           
  Misses            ?    35297           
  Partials          ?     4416
Flag Coverage Δ
#Debug 72.62% <ø> (?)
#production 68.17% <ø> (?)
#test 88.92% <ø> (?)

eerhardt
eerhardt approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks.

Should we also port this to release/1.0?

@sfilipi
Copy link
Member Author

sfilipi commented Apr 5, 2019

Perfect! Thanks.

Should we also port this to release/1.0?

Yes, i can do that.

@sfilipi sfilipi merged commit 8e5c0bb into dotnet:master Apr 5, 2019
@sfilipi sfilipi mentioned this pull request Apr 6, 2019
Closed
sfilipi added a commit to sfilipi/machinelearning-1 that referenced this pull request Apr 9, 2019
@sfilipi
remove unused files. (dotnet#3223)
54e1bbf
@sfilipi sfilipi mentioned this pull request Apr 9, 2019
Closed
@sfilipi sfilipi deleted the removeGplV2FIles branch April 15, 2019 17:15
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@shauheen shauheen Awaiting requested review from shauheen

@glebuk glebuk Awaiting requested review from glebuk

+1 more reviewer

@Ivanidzo4ka Ivanidzo4ka Ivanidzo4ka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sfilipi sfilipi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfilipi @Ivanidzo4ka @eerhardt