Skip to content

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Apr 8, 2019

ONNX scorer transformer sample throws an exception today because it cannot find the model file. This PR fixes that.

fixes #3231

@codemzs codemzs requested a review from sfilipi April 8, 2019 16:09
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 8a03cf9 into dotnet:master Apr 8, 2019
@codecov
Copy link

codecov bot commented Apr 8, 2019

Codecov Report

Merging #3230 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
+ Coverage   72.62%   72.62%   +<.01%     
==========================================
  Files         807      807              
  Lines      145080   145080              
  Branches    16213    16213              
==========================================
+ Hits       105364   105367       +3     
+ Misses      35298    35296       -2     
+ Partials     4418     4417       -1
Flag Coverage Δ
#Debug 72.62% <ø> (ø) ⬆️
#production 68.17% <ø> (ø) ⬆️
#test 88.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.9% <0%> (+0.2%) ⬆️
...StandardTrainers/Standard/LinearModelParameters.cs 60.31% <0%> (+0.26%) ⬆️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 89.89% <0%> (+0.62%) ⬆️

codemzs added a commit to codemzs/machinelearning that referenced this pull request Apr 11, 2019
* Fix bug in ONNX scorer sample.

* PR feedback.
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bug in ONNX scorer sample

3 participants