Skip to content

Conversation

@maryamariyan
Copy link
Contributor

Fix for publishing symbols during official build.

The other 6 tt files in the src/Microsoft.ML.CodeGenerator/Templates/Console/ folder already set linePragmas to false.

Fixes #4400
cc: @eerhardt

@maryamariyan maryamariyan requested a review from eerhardt October 28, 2019 16:28
@maryamariyan maryamariyan requested a review from a team as a code owner October 28, 2019 16:28
@maryamariyan maryamariyan self-assigned this Oct 28, 2019
@eerhardt
Copy link
Member

You need to regenerate the .cs file.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt eerhardt merged commit e730086 into master Oct 29, 2019
@eerhardt eerhardt deleted the packaging branch October 29, 2019 03:12
frank-dong-ms-zz pushed a commit to frank-dong-ms-zz/machinelearning that referenced this pull request Nov 4, 2019
* Add missing linePragmas to ConsumeModel.tt

Fixes dotnet#4400
frank-dong-ms-zz pushed a commit to frank-dong-ms-zz/machinelearning that referenced this pull request Nov 4, 2019
* Add missing linePragmas to ConsumeModel.tt

Fixes dotnet#4400

rebase commits
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while publishing symbols during official build

4 participants