Multi-target with .NET 10. #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can detect and fix any problems when building against newer .NET versions. Also fix any problems, and turn on warnings as errors.
There was a problem hiding this comment.
Pull request overview
This PR adds multi-targeting support to build against .NET 10.0 in addition to existing target frameworks, and enables treat warnings as errors for improved code quality. The changes also update certificate loading code to use the newer X509CertificateLoader API when building for .NET 9.0 or greater.
Changes:
- Added
net10.0as an additional target framework forXamarin.MacDevandUnitTestsprojects - Enabled
TreatWarningsAsErrorsin both project files - Updated certificate loading to use
X509CertificateLoader.LoadCertificatefor .NET 9+ while maintaining backward compatibility withX509Certificate2constructor for older frameworks
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Xamarin.MacDev/Xamarin.MacDev.csproj | Added net10.0 target framework and enabled warnings as errors |
| UnitTests/UnitTests.csproj | Enabled warnings as errors |
| Xamarin.MacDev/MobileProvision.cs | Added conditional compilation to use X509CertificateLoader for .NET 9+ |
| Xamarin.MacDev/Keychain.cs | Added conditional compilation to use X509CertificateLoader for .NET 9+ in two methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mcumming
approved these changes
Jan 15, 2026
dalexsoto
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can detect and fix any problems when building against newer .NET versions.
Also fix any problems, and turn on warnings as errors.