Skip to content

Conversation

@rolfbjarne
Copy link
Member

Then disable it in every file, except a couple where any nullability issues are now fixed.

Then disable it in every file, except a couple where any nullability issues are now fixed.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables nullable reference types for the Xamarin.MacDev project at the project level, then strategically disables it in most files while fixing nullability issues in two interface files.

Changes:

  • Enabled <Nullable>enable</Nullable> in Xamarin.MacDev.csproj
  • Added #nullable disable directives to 20 files with a consistent explanatory comment
  • Fixed nullability issues in IAppleSdkVersion.cs and IAppleSdk.cs

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Xamarin.MacDev/Xamarin.MacDev.csproj Enables nullable reference types at the project level
Xamarin.MacDev/IAppleSdkVersion.cs Adds proper nullable annotations, conditional NotNullWhen attribute, and fixes null checking logic
Xamarin.MacDev/IAppleSdk.cs Enables nullable reference types (no other changes needed)
Xamarin.MacDev/XamMacSdk.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/ProcessArgumentBuilder.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/PlatformAvailability.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/MonoTouchSdk.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/MobileProvisionIndex.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/MobileProvision.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/ManifestExtensions.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/MacOSXSdkVersion.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/MacOSXSdk.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/LoggingService.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/Keychain.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/IPhoneSdkVersion.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/IPhoneImageSizes.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/ExtendedVersion.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/EntitlementExtensions.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/AppleSdkVersion.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/AppleSdkSettings.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/AppleSdk.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/AppleIPhoneSdk.cs Disables nullable reference types with explanatory comment
Xamarin.MacDev/AnalyticsService.cs Disables nullable reference types with explanatory comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rolfbjarne rolfbjarne merged commit f130098 into dotnet:main Jan 15, 2026
8 checks passed
@rolfbjarne rolfbjarne deleted the nullability branch January 15, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants