-
Notifications
You must be signed in to change notification settings - Fork 27
Keys in property list dictionaries aren't necessarily unique. Fixes xamarin-macios#5277. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys in property list dictionaries aren't necessarily unique. Fixes xamarin-macios#5277. #39
Conversation
…amarin-macios#5277. Fixes dotnet/macios#5277.
|
Thanks for tackling this, @rolfbjarne |
spouliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure the last entry wins (e.g. if used from Xcode) ?
or is it a best guess ?
it will solve the exception but it might not produce what's expected
|
@spouliot in the reported case, both plist values are actually the same. But yea, I don't think we know - I think it's a best guess until we get a report where the values are different. Since it's apparently a bug in Apple's web server, it probably won't last long. |
|
This is an example reported on StackOverflow: https://stackoverflow.com/questions/53794998/duplicate-key-in-provisioning-profile-causes-build-failure-error-msb4018/53796567#53796567 |
I tested it: $ cat text.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>key</key>
<string>value</string>
<key>key</key>
<string>second value</string>
</dict>
</plist>
$ /usr/libexec/PlistBuddy -c "Print :key" ./text.plist
second value |
…amarin-macios#5277. (dotnet#39) Fixes dotnet/macios#5277.
…amarin-macios#5277. (dotnet#39) Fixes dotnet/macios#5277.
…amarin-macios#5277. (#39) (#41) Fixes dotnet/macios#5277.
…amarin-macios#5277. (#39) (#40) Fixes dotnet/macios#5277.
Fixes dotnet/macios#5277.