Adjust SDK validation to allow tools/bin and not allow usr/bin. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust SDK validation to find mtouch in a tools/bin directory (which is where mtouch resides when shipped in a nuget package), and not look in usr/bin (mtouch hasn't been there in a long, long time, and then it was very briefly). Simplify the validation logic to output mtouch's actual path instead of a value indicating the subdirectory where it was found. Additionally compute the bin directory to be mtouch's directory, and the lib directory a sibling of the bin directory.
dalexsoto
approved these changes
Mar 5, 2020
spouliot
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust SDK validation to find mtouch in a tools/bin directory (which is where
mtouch resides when shipped in a nuget package), and not look in usr/bin
(mtouch hasn't been there in a long, long time, and then it was very briefly).
Simplify the validation logic to output mtouch's actual path instead of a
value indicating the subdirectory where it was found.
Additionally compute the bin directory to be mtouch's directory, and the lib
directory a sibling of the bin directory.