[Xamarin.MacDev] Add interfaces to bridge Xamarin.iOS- and Xamarin.Mac-specific classes. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rolfbjarne
commented
Apr 27, 2020
rolfbjarne
commented
- Add IAppleSdk interface to bridge AppleSdk and MacOSXSdk.
- Add IAppleSdkVersion interface to bridge IPhoneSdkVersion and MacOXSdkVersion.
…c-specific classes. * Add IAppleSdk interface to bridge AppleSdk and MacOSXSdk. * Add IAppleSdkVersion interface to bridge IPhoneSdkVersion and MacOXSdkVersion.
spouliot
approved these changes
Apr 27, 2020
Xamarin.MacDev/IAppleSdk.cs
Outdated
| public interface IAppleSdk { | ||
| bool IsInstalled { get; } | ||
| string DeveloperRoot { get; } | ||
| string GetPlatformPath (bool is_simulator); |
There was a problem hiding this comment.
minor: iirc fxdg (nor mono) don't suggest underscore in public symbols, including parameters -> pascal case
dalexsoto
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.