[registrar] Cache the System.Void type. #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
force-pushed
the
registrar-cache-system-void
branch
from
7ffbb7f to
dd44e79
Compare
Duration before: 1,60s Duration after: 1,54s Difference: -0,06s = -3,8% Memory usage hardly changed (-21 kb of 540 MB), but the number of method calls shrunk significantly. Method calls before: 86.720.379 Method calls after: 74.390.061 Difference: -12.330.318 = -14,2% The call to `GetSystemVoidType` was #2 on the list of method calls (whens sorted by 'self'), called 1072 times taking 1429 ms each time. After this change it's only called once (and obviously pushed way down the list).
rolfbjarne
force-pushed
the
registrar-cache-system-void
branch
from
dd44e79 to
4982822
Compare
Collaborator
|
Build failure |
Member
Author
|
build |
Collaborator
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory usage hardly changed (-21 kb of 540 MB), but the number of method calls
shrunk significantly.
The call to
GetSystemVoidTypewas #2 on the list of method calls (whenssorted by 'self'), called 1072 times taking 1429 ms each time. After this
change it's only called once (and obviously pushed way down the list).