[msbuild] Unify handling of Sdks. #10375
Conversation
Create an Sdks class in Xamarin.MacDev.Tasks.Core, which handles both Xamarin.iOS and Xamarin.Mac. Refactor the MacOSXSdks and IPhoneSdks classes to use the new Sdks class. This makes it possible to avoid some code duplication in MacOSXSdks and IPhoneSdks, and also share code elsewhere. This requires a bump of Xamarin.MacDev. New commits in xamarin/Xamarin.MacDev: * dotnet/macios-devtools@fae0237 [Xamarin.MacDev] Add GetAppleDTSettings and GetSdkSettings to the IAppleSdk interface. (dotnet#85) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/f665e3a0fccce24b9dbb31650f99ef2c73ba4d46..fae0237704b792004adf592d8c9038a9d46aafff
| return TVOS; | ||
| case ApplePlatform.MacOSX: | ||
| return MacOS; | ||
| case ApplePlatform.MacCatalyst: |
There was a problem hiding this comment.
minor/style: could be moved next to case ApplePlatform.iOS: since they share (a copy of) the same code
| case ApplePlatform.MacCatalyst: | ||
| return IOS; | ||
| default: | ||
| throw new InvalidOperationException (string.Format ("Invalid framework: {0}", framework)); |
There was a problem hiding this comment.
not a new issue but... should not this be translated like other messages ?
❌ Device tests failed on Build ❌Device tests failed on Build. Test results2 tests failed, 39 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096' |
|
Test failures are unrelated: https://github.com/xamarin/maccore/issues/2357 |
|
Build failure |
❌ Device tests failed on Build ❌Device tests failed on Build. Test results3 tests failed, 38 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097' |
|
Build failure Test results1 tests failed, 89 tests passed.Failed tests
|
❌ Tests failed on Build ❌Tests failed on Build. Test results1 tests failed, 40 tests passed.Failed tests
Pipeline on Agent XAMBOT-1095 |
|
Test failures are known issues:
|
8 participants
Create an Sdks class in Xamarin.MacDev.Tasks.Core, which handles both Xamarin.iOS
and Xamarin.Mac. Refactor the MacOSXSdks and IPhoneSdks classes to use the new Sdks
class.
This makes it possible to avoid some code duplication in MacOSXSdks and IPhoneSdks,
and also share code elsewhere.
This requires a bump of Xamarin.MacDev.
New commits in xamarin/Xamarin.MacDev:
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/f665e3a0fccce24b9dbb31650f99ef2c73ba4d46..fae0237704b792004adf592d8c9038a9d46aafff