.NET 6 templates for iOS, macOS, tvOS, & MacCatalyst by jonathanpeppers · Pull Request #10741 · dotnet/macios

jonathanpeppers · 2021-02-26T22:41:11Z

Context: https://docs.microsoft.com/dotnet/core/tutorials/cli-templates-create-template-pack
Context: https://github.com/dotnet/templating/wiki
Context: dotnet/designs#120
Fixes: #10252

To implement templates in a .NET workload:

Make .nupkg files that follow the structure of the dotnet new
templating system, using $(PackageType) of Template.
Install the .nupkg files in in dotnet/template-packs/
Update WorkloadManifest.json, to be part of the workload:

"Microsoft.@PLATFORM@.Templates": {
  "kind": "template",
  "version": "@VERSION@"
}

These are a starting point, for what I would consider the minimum for
the xamarin-macios repo to provide for now:

Template Name                                 Short Name      Language    Tags
--------------------------------------------  --------------  ----------  ----------------------
iOS Controller template                       ios-controller  [C#]        iOS
iOS Application                               ios             [C#]        iOS
iOS Class library                             ioslib          [C#]        iOS
macOS Application                             macos           [C#]        macOS
MacCatalyst Application                       maccatalyst     [C#]        macOS/Catalyst
tvOS Application                              tvos            [C#]        tvOS

We will probably need PM input on what the final templates will be.

To use these, you might do:

$ mkdir MyApp && cd MyApp
$ dotnet new ios
$ dotnet new ios-controller --name LoginController --namespace MyApp

vs-mobiletools-engineering-service2 · 2021-02-27T05:11:25Z

✅ Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

🎉 All 182 tests passed 🎉

Pipeline on Agent XAMBOT-1095'

rolfbjarne · 2021-03-01T07:30:51Z

+    public class Application
+    {
+        // This is the main entry point of the application.
+        static void Main(string[] args)


Do template code need to use a specific coding style? Or will they be reformatted according to the user's settings when they're instantiated?

There is a dotnet format tool: https://www.hanselman.com/blog/editorconfig-code-formatting-from-the-command-line-with-net-cores-dotnet-format-global-tool

I tested this, I copied the .editorconfig from xamarin-android, then did:

% dotnet new ios % dotnet format

When I saw other templates, they all use VS Windows coding style -- but I guess it could really be any style? I think dotnet format would fix up anything.

That tools looks pretty amazing!

Its mere existence makes me vote towards having the templates use our own coding style (in which case the coding style is wrong in some of the new files - I guess you could run dotnet format locally in the template directory and that'll fix it 😄 )

spouliot

How does it compare with what we ship today ? https://github.com/xamarin/xamarin-templates

This should not fix (close) the dotnet issue until the work is completed (or we risk losing track of the task)

spouliot · 2021-03-01T14:21:53Z

+        public override bool FinishedLaunching(UIApplication application, NSDictionary launchOptions)
+        {
+            // create a new window instance based on the screen size
+            Window = new UIWindow(UIScreen.MainScreen.Bounds);


source code format is inconsistent, e.g. space before (

Should I dotnet format every template to use default VS settings?

Or should I dotnet format using the .editorconfig in xamarin-macios?

as much as I'd like to use our (mono) style it's likely best to follow VS[4m] style used for other templates

jonathanpeppers · 2021-03-01T16:13:27Z

How does it compare with what we ship today ? https://github.com/xamarin/xamarin-templates

@spouliot I got these files from here ^^ I should have put that in the commit message. I didn't change anything (intentionally) other than port them to .NET 6.

For the Mac template I created a new project in latest VS Mac -- I didn't find a Mac template in xamarin-templates.

jonathanpeppers · 2021-03-01T18:09:22Z

@spouliot as for the issues, I think this one should close #10252, as I think it is matching parity with what Android had for .NET 6 Preview 1.

I filed new issues to "finish" the templates:

@Version

Context: https://docs.microsoft.com/dotnet/core/tutorials/cli-templates-create-template-pack Context: https://github.com/dotnet/templating/wiki Context: dotnet/designs#120 Fixes: dotnet#10252 To implement templates in a .NET workload: 1. Make `.nupkg` files that follow the structure of the `dotnet new` templating system, using `$(PackageType)` of `Template`. 2. Install the `.nupkg` files in in `dotnet/template-packs/` 3. Update `WorkloadManifest.json`, to be part of the workload: "Microsoft.@platform@.Templates": { "kind": "template", "version": "@Version@" } These are a starting point, for what I would consider the minimum for the xamarin-macios repo to provide for now: Template Name Short Name Language Tags -------------------------------------------- -------------- ---------- ---------------------- iOS Controller template ios-controller [C#] iOS iOS Application ios [C#] iOS iOS Class library ioslib [C#] iOS macOS Application macos [C#] macOS MacCatalyst Application maccatalyst [C#] macOS/Catalyst tvOS Application tvos [C#] tvOS We will probably need PM input on what the final templates will be. To use these, you might do: $ mkdir MyApp && cd MyApp $ dotnet new ios $ dotnet new ios-controller --name LoginController --namespace MyApp Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

jonathanpeppers · 2021-03-01T19:59:01Z

Latest changes:

Ran dotnet format on all the templates using this repo's .editorconfig.
- I had to manually rename any *.designer.cs file so they would be formatted, too. (I think I got them all)
I updated the tags on MacCatalyst:

Template Name                                 Short Name      Language    Tags
--------------------------------------------  --------------  ----------  ----------------------
iOS Controller template                       ios-controller  [C#]        iOS
iOS Application                               ios             [C#]        iOS
iOS Class library                             ioslib          [C#]        iOS
macOS Application                             macos           [C#]        macOS
MacCatalyst Application                       maccatalyst     [C#]        macOS/Catalyst
tvOS Application                              tvos            [C#]        tvOS

dalexsoto

👏

vs-mobiletools-engineering-service2 · 2021-03-02T02:34:25Z

✅ Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

🎉 All 182 tests passed 🎉

Pipeline on Agent XAMBOT-1099'

jonathanpeppers requested a review from rolfbjarne as a code owner February 26, 2021 22:41

jonathanpeppers commented Feb 26, 2021

View reviewed changes

Comment thread dotnet/Microsoft.MacCatalyst.Templates/maccatalyst/MacCatalystApp1.csproj

rolfbjarne approved these changes Mar 1, 2021

View reviewed changes

spouliot added the not-notes-worthy Ignore for release notes label Mar 1, 2021

spouliot reviewed Mar 1, 2021

View reviewed changes

jonathanpeppers mentioned this pull request Mar 1, 2021

Finish templates #10747

Closed

spouliot approved these changes Mar 1, 2021

View reviewed changes

jonathanpeppers force-pushed the dotnet-templates branch from acbc7c7 to 4614f6c Compare March 1, 2021 19:56

tj-devel709 approved these changes Mar 1, 2021

View reviewed changes

dalexsoto approved these changes Mar 1, 2021

View reviewed changes

jonathanpeppers merged commit 11ca5a8 into dotnet:main Mar 2, 2021

jonathanpeppers deleted the dotnet-templates branch March 2, 2021 15:23

Conversation

jonathanpeppers commented Feb 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 27, 2021

✅ Tests passed on Build. ✅

API diff

🎉 All 182 tests passed 🎉

Uh oh!

Uh oh!

rolfbjarne Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

spouliot Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

spouliot Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jonathanpeppers commented Mar 1, 2021

Uh oh!

jonathanpeppers commented Mar 1, 2021

Uh oh!

jonathanpeppers commented Mar 1, 2021

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2021

✅ Tests passed on Build. ✅

API diff

🎉 All 182 tests passed 🎉

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jonathanpeppers commented Feb 26, 2021 •

edited

Loading

jonathanpeppers Mar 1, 2021 •

edited

Loading