[msbuild] Make actool work correctly for Mac Catalyst apps by passing '--ui-framework-family uikit'. Fixes #10804.#10815
Merged
rolfbjarne merged 2 commits intodotnet:mainfrom Mar 10, 2021
Conversation
… '--ui-framework-family uikit'. Fixes dotnet#10804. Also * Fix the Mac Catalyst sample to use the correct contents.json and images sizes for Mac Catalyst app icons. * Fix the contents.json and image sizes for the Mac Catalyst test project as well. * Add unit test for Mac Catalyst that ensures that Assets.car is in the final app. Fixes dotnet#10804.
spouliot
approved these changes
Mar 9, 2021
dalexsoto
approved these changes
Mar 9, 2021
mauroa
approved these changes
Mar 9, 2021
tj-devel709
approved these changes
Mar 9, 2021
Collaborator
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results122 tests failed, 60 tests passed.Failed tests
Pipeline on Agent XAMBOT-1095' |
mandel-macaque
approved these changes
Mar 9, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
for Mac Catalyst app icons.
Fixes #10804.