Skip to content

Conversation

@rolfbjarne
Copy link
Member

commit mono/mono@72e13f4
Author: Rolf Bjarne Kvinge rolf@xamarin.com
Date: Wed Nov 2 15:51:09 2016 +0100

[System.Net.Http] Fix HttpClient test after we started throwing PlatformNotSupportedExceptions in WebRequest.GetSystemWebProxy for watchOS.

Fix HttpClient test after we started throwing PlatformNotSupportedExceptions
in WebRequest.GetSystemWebProxy in 99f2e7d36d544f903bc3931db598137f087e5b2c.

commit mono/mono@72e13f4
Author: Rolf Bjarne Kvinge <rolf@xamarin.com>
Date:   Wed Nov 2 15:51:09 2016 +0100

    [System.Net.Http] Fix HttpClient test after we started throwing PlatformNotSupportedExceptions in WebRequest.GetSystemWebProxy for watchOS.

    Fix HttpClient test after we started throwing PlatformNotSupportedExceptions
    in WebRequest.GetSystemWebProxy in 99f2e7d36d544f903bc3931db598137f087e5b2c.
@rolfbjarne rolfbjarne added the requires-approval-before-merge The pull request requires special approval before it can be merged label Nov 3, 2016
@monojenkins
Copy link
Collaborator

Build failure

!!! Couldn't read commit file !!!

@rolfbjarne
Copy link
Member Author

The test failure is unrelated (XM/introspection crash: bug #46115)

@spouliot
Copy link
Contributor

spouliot commented Nov 3, 2016

@pjcollins this is a test-only change on cycle8-xi to fix test-bcl-sim-System.Net.Http, see https://wrench.internalx.com/Wrench/ViewTable.aspx?lane_id=3969&host_id=243

@spouliot
Copy link
Contributor

spouliot commented Nov 4, 2016

Confirmed with @pjcollins

@spouliot spouliot merged commit ba3ab9c into dotnet:cycle8-xi Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-approval-before-merge The pull request requires special approval before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants