[MediaPlayer] Add Support for DotNet Attributes #12538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 24, 2021 19:44
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 104 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
rolfbjarne
approved these changes
Aug 25, 2021
spouliot
approved these changes
Aug 25, 2021
mandel-macaque
suggested changes
Aug 25, 2021
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
Small fixes with the strings, great work!
src/MediaPlayer/MPVolumeSettings.cs
Outdated
| #else | ||
| [UnsupportedOSPlatform ("ios11.3")] | ||
| #if IOS | ||
| [Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
Member
Author
There was a problem hiding this comment.
Good catch, I thought this looked a little fishy too haha I'll change those!
src/MediaPlayer/MPVolumeSettings.cs
Outdated
| #else | ||
| [UnsupportedOSPlatform ("ios11.3")] | ||
| #if IOS | ||
| [Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
src/MediaPlayer/MPVolumeSettings.cs
Outdated
| #else | ||
| [UnsupportedOSPlatform ("ios11.3")] | ||
| #if IOS | ||
| [Obsolete ("Starting with ios11.3 Use 'MPVolumeView' to present volume controls.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
| #else | ||
| [UnsupportedOSPlatform ("ios15.0")] | ||
| #if IOS | ||
| [Obsolete ("Starting with ios15.0 The iAd framework has been removed from iOS.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")] |
Contributor
|
👀 |
mandel-macaque
approved these changes
Aug 25, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results25 tests failed, 83 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
Collaborator
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1106.BigSur' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.