[dotnet] Show an error if we must link, but linking has been disabled. Fixes #12372. #12832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes dotnet#12372. For executable projects, we must run the linker (otherwise we won't produce something that can be executed). We'll enable the linker by default in these cases, but if the developer has manually disabled the linker (if the linker fails to execute for any reason, it will suggest that the developer disables it), then we should show an error explaining why. Fixes dotnet#12372.
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Sep 24, 2021
dalexsoto
approved these changes
Sep 24, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 133 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
tj-devel709
approved these changes
Sep 24, 2021
Member
Author
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For executable projects, we must run the linker (otherwise we won't produce
something that can be executed).
We'll enable the linker by default in these cases, but if the developer has
manually disabled the linker (if the linker fails to execute for any reason,
it will suggest that the developer disables it), then we should show an error
explaining why.
Fixes #12372.