Skip to content

[Foundation] Add NSArray.ToArray and implement IEnumerable<NSObject>.#16252

Merged
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:nsarray-improvements
Oct 6, 2022
Merged

[Foundation] Add NSArray.ToArray and implement IEnumerable<NSObject>.#16252
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:nsarray-improvements

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

For NSArray, implement:

  • A ToArray () method that returns an NSArray[].
  • A ToArray () method that returns a T[].
  • The IEnumerable interface.

For NSArray, implement:

  • A ToArray () method that returns a T[].

This should make NSArray much better to work with from managed code.

For NSArray, implement:

* A ToArray () method that returns an NSArray[].
* A ToArray<T> () method that returns a T[].
* The IEnumerable<NSObject> interface.

For NSArray<T>, implement:

* A ToArray () method that returns a T[].

This should make NSArray much better to work with from managed code.
@rolfbjarne rolfbjarne requested a review from chamons as a code owner October 5, 2022 16:39
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Oct 5, 2022
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: d841b0e731da6c0701b1ec6e3d0d55d990034171 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1023.Monterey'
Hash: d841b0e731da6c0701b1ec6e3d0d55d990034171 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • introspection

Pipeline on Agent
Hash: d841b0e731da6c0701b1ec6e3d0d55d990034171 [PR build]

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne rolfbjarne merged commit 273c2fa into dotnet:main Oct 6, 2022
@rolfbjarne rolfbjarne deleted the nsarray-improvements branch October 6, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants