-
Notifications
You must be signed in to change notification settings - Fork 554
[XM] Add the option to ignore missing files during registration #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not all assemblies referenced at compile time are necessary at runtime. Allow XamMac to ignore missing assemblies just like iOS does. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=51746
|
Hi @alanmcgovern, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
/cc @chamons |
|
Build failure |
spouliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the comment on iOS is correct only for the simulator (JIT) and should be updated before merging (linking and AOT'ing impose restriction on missing code).
|
I wasn't sure what the implications are so i don't know how the comment should be updated. I just wanted to push a POC while they details are hammered out so I can investigate stripping out 20MB of files from our zip :) |
chamons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
|
I will fix the build failure. |
|
Build success |
|
I'll grab this build shortly and see how much junk I can strip out from our XVS integration now. Thanks! :D |
|
Hi @alanmcgovern and @chamons , I'm using VS for Mac Preview #5 . When I go to Visual Studio >About Visual Studio > Show Details it shows: Xamarin.Mac How can I upgrade to the version that contains this fix? (it looks like it is xamarin-mac-3.2.0.20). Thanks for your help! |
|
@TonyValenti The standard place to discuss things like this is either the dev gitter: https://gitter.im/xamarin/xamarin-macios or the XM forums: https://forums.xamarin.com/categories/mac You are welcome to build everything by hand (https://github.com/xamarin/xamarin-macios/blob/master/README.md) but it can be non-trivial to setup and if you just want a recent build is unnecessary as they are published on Jenkins: https://jenkins.mono-project.com/view/Xamarin.MaciOS/job/xamarin-macios-builds-master/ |
Not all assemblies referenced at compile time are necessary
at runtime. Allow XamMac to ignore missing assemblies just
like iOS does.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=51746