Skip to content

Conversation

@alanmcgovern
Copy link
Contributor

Not all assemblies referenced at compile time are necessary
at runtime. Allow XamMac to ignore missing assemblies just
like iOS does.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=51746

Not all assemblies referenced at compile time are necessary
at runtime. Allow XamMac to ignore missing assemblies just
like iOS does.

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=51746
@dnfclas
Copy link

dnfclas commented Feb 17, 2017

Hi @alanmcgovern, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@alanmcgovern
Copy link
Contributor Author

/cc @chamons

@monojenkins
Copy link
Collaborator

Build failure

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the comment on iOS is correct only for the simulator (JIT) and should be updated before merging (linking and AOT'ing impose restriction on missing code).

@alanmcgovern
Copy link
Contributor Author

I wasn't sure what the implications are so i don't know how the comment should be updated. I just wanted to push a POC while they details are hammered out so I can investigate stripping out 20MB of files from our zip :)

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chamons
Copy link
Contributor

chamons commented Feb 21, 2017

I will fix the build failure.

@monojenkins
Copy link
Collaborator

Build success

@chamons chamons merged commit 0963ba1 into master Feb 22, 2017
@chamons chamons deleted the ignore_missing_assemblies branch February 22, 2017 15:18
@alanmcgovern
Copy link
Contributor Author

I'll grab this build shortly and see how much junk I can strip out from our XVS integration now. Thanks! :D

@TonyValenti
Copy link

Hi @alanmcgovern and @chamons ,
I'm new to Xamarin / Visual Studio for Mac so if I'm posting in the wrong place, I'm sorry.

I'm using VS for Mac Preview #5 . When I go to Visual Studio >About Visual Studio > Show Details it shows:

Xamarin.Mac
Version: 3.0.0.393 (Visual Studio Enterprise)

How can I upgrade to the version that contains this fix? (it looks like it is xamarin-mac-3.2.0.20).

Thanks for your help!

@chamons
Copy link
Contributor

chamons commented Mar 20, 2017

@TonyValenti The standard place to discuss things like this is either the dev gitter:

https://gitter.im/xamarin/xamarin-macios

or the XM forums:

https://forums.xamarin.com/categories/mac

You are welcome to build everything by hand (https://github.com/xamarin/xamarin-macios/blob/master/README.md) but it can be non-trivial to setup and if you just want a recent build is unnecessary as they are published on Jenkins:

https://jenkins.mono-project.com/view/Xamarin.MaciOS/job/xamarin-macios-builds-master/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants