Try to fix build of PR #31 #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rewrite of the ModernHttpClient version of NSUrlSessionHandler, it has better handling for memory that provides a more consistant memory footprint. It accomplishes this by using NSInputStream for requests, and reading and disposing directly from NSData instead of transitioning the NSData to a byte[] array.
Collaborator
|
Build success |
Contributor
Author
|
That solved the build issue. There's one breaking change in the API: and it seems that the properties from
are no longer honoured, so they will be broken as the PR currently stands. |
Collaborator
|
Build success |
spouliot
added
the
requires-qa-before-merge
Mostly my comments in PR dotnet#174 * Add support for redirection [1] * Add support for credentials [1] * Add support for caching [2] * Remove 2nd dictionary lookup in GetHeaderSeparator * Avoid extraneous cast for credentialsToUse PR 177 [3] adds tests that ensure no commits can remove, or change default values, for handlers. [1] breaking changes (feature, not API) [2] breaking change (API removal) [3] dotnet#177
Collaborator
|
Build success |
Contributor
Author
|
@nberardi QA tests failed as the new implementation hangs while running one of our sample: https://github.com/xamarin/monotouch-samples/tree/master/HttpClient I'll have a look again later, but we're busy with WWDC/Xcode8 right now - in case you want to see what's going :) |
Contributor
|
@spouliot I will have a look. Can I have access to the test procedures or script so that I can run in the same way the automated tests run? |
Contributor
|
I have been able to reproduce the hang on the HTTPS request. Is that what you are also seeing? |
mandel-macaque
pushed a commit
that referenced
this pull request
Sep 20, 2016
Mostly my comments in PR #174 * Add support for redirection [1] * Add support for credentials [1] * Add support for caching [2] * Remove 2nd dictionary lookup in GetHeaderSeparator * Avoid extraneous cast for credentialsToUse PR 177 [3] adds tests that ensure no commits can remove, or change default values, for handlers. [1] breaking changes (feature, not API) [2] breaking change (API removal) [3] #177
Contributor
Merged
mandel-macaque
pushed a commit
that referenced
this pull request
Oct 3, 2016
* Added rewritten NSUrlSessionHandler that handles memory better This is a rewrite of the ModernHttpClient version of NSUrlSessionHandler, it has better handling for memory that provides a more consistant memory footprint. It accomplishes this by using NSInputStream for requests, and reading and disposing directly from NSData instead of transitioning the NSData to a byte[] array. * Try to fix build of PR #31 * [foundation] Restore compatibility with the new NSUrlSessionHandler Mostly my comments in PR #174 * Add support for redirection [1] * Add support for credentials [1] * Add support for caching [2] * Remove 2nd dictionary lookup in GetHeaderSeparator * Avoid extraneous cast for credentialsToUse PR 177 [3] adds tests that ensure no commits can remove, or change default values, for handlers. [1] breaking changes (feature, not API) [2] breaking change (API removal) [3] #177 * [foundation] Restore compatibility with the new NSUrlSessionHandler Mostly my comments in PR #174 * Add support for redirection [1] * Add support for credentials [1] * Add support for caching [2] * Remove 2nd dictionary lookup in GetHeaderSeparator * Avoid extraneous cast for credentialsToUse PR 177 [3] adds tests that ensure no commits can remove, or change default values, for handlers. [1] breaking changes (feature, not API) [2] breaking change (API removal) [3] #177 * Try to fix build of PR #31 * prevent DEADLOCK in UI code * Added ConfigureAwait(false) to Task.Delay to prevent DEADLOCK when the stream is being awaited on the UI thread * added a few more ConfigureAwait(false) statments that were missed on first pass * Fix some small style issues. * Set the default value of AllowAutoRedirect to true.
Contributor
|
Closing this as #932 landed with the same changes and extra fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.