Fixes for XM 4.5 and netstandard13 and updated comments #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chamons
commented
Feb 23, 2017
chamons
commented
- It turns out that a majority of the pain was due to HintPaths pointing to netstandard13 facades directly in the project in question
- There was one bug in mmp that was fixed
- I expanded the comments in XM45.targets files to prevent myself/others from being confused more than necessary
- MSBuild + netstandard13 is busted and will be fixed in another PR
- There is only one folder inside XM where we store the assemblies, 4.5 - Yes, this increasing shows how terrible the name XM 4.5 is
- MSBuild with XM 4.5 is still broken
spouliot
approved these changes
Feb 23, 2017
|
|
||
| <!-- The XM 4.5 target framework (will hopefully be renamed at some point) is a bit of a strange case --> | ||
| <!-- It does not declare a TargetFrameworkIdentifier so it can be compatible with "Desktop" nugets --> | ||
| <!-- These days it could have been done with some paches to nuget and such, but now can not be changed --> |
Collaborator
|
Build failure |
1 similar comment
Collaborator
|
Build failure |
rolfbjarne
approved these changes
Feb 24, 2017
… nugets with same name as Facades
Collaborator
|
Build failure |
…ich is not desired
Collaborator
|
Build failure |
Contributor
Author
|
Random test failure - https://bugzilla.xamarin.com/show_bug.cgi?id=52173 |
chamons
added a commit
that referenced
this pull request
Feb 27, 2017
- Update comments on XM45.targets file - Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades - Note: MSBuild with XM 4.5 is still broken for now
chamons
added a commit
that referenced
this pull request
Mar 6, 2017
- Update comments on XM45.targets file - Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades - Note: MSBuild with XM 4.5 is still broken for now
spouliot
pushed a commit
that referenced
this pull request
Mar 7, 2017
rolfbjarne
pushed a commit
to rolfbjarne/macios
that referenced
this pull request
Mar 9, 2017
- Update comments on XM45.targets file - Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades - Note: MSBuild with XM 4.5 is still broken for now
rolfbjarne
pushed a commit
that referenced
this pull request
Mar 9, 2017
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Mar 27, 2017
…dotnet#1777) - Update comments on XM45.targets file - Remove unnecessary AssemblySearchPaths hack causing issues using nugets with same name as Facades - Note: MSBuild with XM 4.5 is still broken for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.