Add mmp support for AOT options in XS #1818

timrisi · 2017-03-02T22:31:17Z

This is needed to be able to add the AOT options in the xamarin.mac build options in xamarin studio

spouliot · 2017-03-02T23:32:05Z

msbuild/Xamarin.Mac.Tasks.Core/Tasks/MmpTaskBase.cs

 		public string ExtraArguments { get; set; }

+		public string AOTMode { get; set; }
+		public bool HybridAOT { get; set; }


it sounds a bit confusing to to have AOTMode and then HybridAOT which is a mode

Maybe seeing a pic of the UI would help, but I think the terms could be clearer

I'd go for AOTMode and HybridAOTOption

AOTScope maybe (based on sebastians comment below)?

Related: Should it just be AotScope, etc for the names instead? Similar to how we rename NSURL names to NSUrl

timrisi · 2017-03-02T23:43:45Z

AOTMode is the dropdown, for None, Core, SDK or All. If it's set to anything but None, the checkbox and textbox are enabled. HybridAOT for the checkbox defaults to false, textbox defaults to empty (I'd been messing with the options in the above SS).

I'm definitely open to changing the variable names.

monojenkins · 2017-03-02T23:45:46Z

Build success

spouliot · 2017-03-03T01:12:01Z

Ok, I think Mode should be reserved for Normal, Hybrid or Full (even if the last does not apply here today). It's already the term used between normal and full AOT builds on iOS.

It seems to me that Scope or Set would better terms, as the option defines a predefined set of assemblies where AOT would be applied.

I'm not sure a text box is a good UI for listing assemblies, even more if it deals with both addition and removals (it means you have to know the syntax). There's already a text box for Additional mmp arguments that can be used for advanced options. Maybe that text box can be removed ?

@VincentDondain is there another way (e.g. in referenced assemblies) that we could show/select assemblies for "AOT > No, Normal, Hybrid" ?

spouliot · 2017-03-03T01:13:28Z

hmmm, the last part (of my previous comment) was not written is the right PR. Let's just focus on my two first paragraphs for this PR :-)

VincentDondain · 2017-03-03T01:21:48Z

I agree with @spouliot on the fact that "Include/exclude assemblies from AOT compilation" is a bit too advanced and could be reserve for use in the additional mmp arguments (simplifying the build options).

@spouliot about the last comment, you're talking about that?

Like we'd right click on some assemblies and select an AOT mode? Kinda like build actions on files?

timrisi · 2017-03-03T01:23:07Z

The UI discussion should probably move to the PR where those are actually implemented

VincentDondain · 2017-03-03T01:23:55Z

Ah damn I didn't notice we were in xamarin-macios I just jumped on the comments from my emails (:

VincentDondain · 2017-03-03T01:25:58Z

Moved the UI conversation to https://github.com/xamarin/md-addins/pull/1511#issuecomment-283837282

monojenkins · 2017-03-03T21:40:31Z

Build failure

monojenkins · 2017-03-03T22:57:30Z

Build failure

timrisi · 2017-03-16T21:03:22Z

Failure unrelated: https://bugzilla.xamarin.com/show_bug.cgi?id=52538

spouliot · 2017-03-17T03:38:09Z

@timrisi you can merge (like it was a green checkmark) once you identified (or filed) the unrelated failure

This is in part so we get xamarin/maccore#1924 -> [mlaunch] Connect to devices on a background thread. That should hopefully fix device not found issues we're having on some bots/ New commits in xamarin/macios-binaries: * xamarin/macios-binaries@01d34af Bump mlaunch to xamarin/maccore@809b2def39 (dotnet#24) Diff: https://github.com/xamarin/macios-binaries/compare/b474fa2e732974fde2edbfe054f23c5eefd0255b..01d34af6b03e81cefbb30d964e58fca66da86c4a New commits in xamarin/maccore: * xamarin/maccore@809b2def39 [mlaunch] Connect to devices on a background thread. (dotnet#1778) (dotnet#1924) * xamarin/maccore@5215c09e8c Merge pull request dotnet#1923 from xamarin/swift-o-matic-hello-protocol-list-type * xamarin/maccore@21447e2538 I. Can't. Believe. I'm. Checking. This. In. * xamarin/maccore@da6518f920 Added ProtocolListTypeSpec * xamarin/maccore@a9b9a0f5b3 Merge pull request dotnet#1920 from xamarin/swift-o-matic-bye-swift-protocol * xamarin/maccore@01e9420598 Lose all the SwiftProtocol related types. * xamarin/maccore@ca3bd0ab5b Merge pull request dotnet#1919 from xamarin/swift-redo-regular-protocols * xamarin/maccore@f534abee12 Now with existential containers * xamarin/maccore@9e180a823a Merge pull request dotnet#1911 from xamarin/swift-o-matic-string-convertible * xamarin/maccore@9874985856 Typo * xamarin/maccore@26731ff5cb Next step in Protocol revamp * xamarin/maccore@9fe4cdd652 Merge pull request dotnet#1904 from xamarin/swift-o-matic-hashable * xamarin/maccore@a1cd988dda iOS include * xamarin/maccore@f1fc694da6 Revamped hashable. * xamarin/maccore@16a6629a43 Merge pull request dotnet#1902 from xamarin/swift-o-matic-comparable * xamarin/maccore@a98db5b976 Dead symbol, changed symbol. * xamarin/maccore@3c38895694 Reworked Swift.Comparable to be defined in terms of EveryProtocol * xamarin/maccore@ef1d3c1397 Merge pull request dotnet#1895 from xamarin/swift-o-matic-equatable * xamarin/maccore@1c1a57fa4f Try again and get all the files, thanks. * xamarin/maccore@ec0a5b99b7 Revised EveryProtocol, updated Equatable * xamarin/maccore@198a489387 Simplified EveryProtocol, revised Equatable * xamarin/maccore@ee7710a186 Merge pull request dotnet#1894 from xamarin/swift-o-matic-every-protocol * xamarin/maccore@4fc0810fd2 Let's not leak memory, OK? * xamarin/maccore@451c0ba18d Try a little dispose magic. * xamarin/maccore@864854e407 Minor tweak to public API * xamarin/maccore@052990af11 Adding in EveryProtocol object * xamarin/maccore@b7f1347fcf Merge pull request dotnet#1893 from xamarin/swift-o-matic-protocol-binding * xamarin/maccore@df4aefe447 no swap files, vi. * xamarin/maccore@1e6bf8d4ef Merge pull request dotnet#1892 from xamarin/swift-o-matic-protocol-binding * xamarin/maccore@e46a543544 Typo * xamarin/maccore@fea9514c69 Let's document! * xamarin/maccore@9b5ecdfdce Merge pull request dotnet#1890 from xamarin/swift-o-matic-fail-on-wrong-version * xamarin/maccore@0b4afae5f3 Put in a hard fail on compiler version mismatch errors. * xamarin/maccore@d1475a43d1 Merge pull request dotnet#1881 from xamarin/swift-o-matic-NRE * xamarin/maccore@900e453695 Fixes and NRE from SCLAlertView * xamarin/maccore@0164c0ae83 Merge pull request dotnet#1873 from xamarin/swift-o-matic-README * xamarin/maccore@211b05a515 READMEs for errors, reminder to check README and associated issues in Makefile * xamarin/maccore@74650bf3f8 [SoM] Add '/usr/lib/swift' as an rpath before any other rpaths. (dotnet#1857) * xamarin/maccore@73dd23d00b Merge pull request dotnet#1859 from xamarin/swift-o-matic-SwiftLocation * xamarin/maccore@6704604de1 Add SwiftLocation * xamarin/maccore@e96ab505d8 Merge pull request dotnet#1855 from xamarin/swift-o-matic-bye-bye-dormant-3rd-party * xamarin/maccore@c17c506738 Remove dormant 3rd Party Tests * xamarin/maccore@366e201f11 Merge pull request dotnet#1854 from xamarin/swift-o-matic-update-3rd-party * xamarin/maccore@da748a9a1d Updated makefiles for projects that have updated to Swift 4.2 or > * xamarin/maccore@2e371bdaf2 Merge pull request dotnet#1849 from xamarin/swift-o-matic-gentler-errors * xamarin/maccore@921c21251d Lighten up on errors, get paper-switch * xamarin/maccore@f4fc280efe Merge pull request dotnet#1844 from xamarin/swift-o-matic-lottie * xamarin/maccore@e47aa6b50c Adding lottie-ios * xamarin/maccore@cf09fd4c59 [SoM] Copy swift libraries to foo.app/Frameworks for non-macOS apps. (dotnet#1842) * xamarin/maccore@a4af9cdd2d Merge pull request dotnet#1841 from xamarin/swift-o-matic-gentler-skip * xamarin/maccore@fc7cd38f64 [SoM] Handle the new BuildVersion load command. (dotnet#1827) * xamarin/maccore@8666e81b7d Ha-ha! When you make errors become warnings, tests that depend on errors change. * xamarin/maccore@e42a8c394f continue... * xamarin/maccore@3b0d6bc0e6 [SoM] Don't duplicate the nuget version number. (dotnet#1838) * xamarin/maccore@143afaf991 [msbuild] No need to use a shell function to resolve a relative path in make. (dotnet#1839) * xamarin/maccore@cbe86e0152 [SoM] Add a helpful make target to create a nuget and setup a local feed repository for it. (dotnet#1837) * xamarin/maccore@cfaaf1c5a5 [SoM] Enable swift's Stable ABI. (dotnet#1836) * xamarin/maccore@79166d9755 Made errors more lenient, added Hue framework. * xamarin/maccore@f4b0feeb55 Merge pull request dotnet#1830 from xamarin/swift-o-matic-prop-closure * xamarin/maccore@a14198fdee whitespace * xamarin/maccore@285874eceb handle ()->() and ()->type properly * xamarin/maccore@4785afe4ea Handle closures as return values. * xamarin/maccore@e89b80ca53 [SoM] Don't redownload the swift toolchain if we already have the file. (dotnet#1825) * xamarin/maccore@217a608e72 [SoM] Improve installed scripts. (dotnet#1826) * xamarin/maccore@ff283225b6 [SoM] Fix typo in type name. (dotnet#1824) * xamarin/maccore@189ea0cba7 Merge pull request dotnet#1818 from xamarin/swift-o-matic-SwiftMessages-NRE * xamarin/maccore@937541e0a6 restore back original code. * xamarin/maccore@30be8a354a continue on null * xamarin/maccore@dfceb83692 Merge pull request dotnet#1816 from xamarin/swift-o-matic-warn-not-fail * xamarin/maccore@b32e33e71d Make warnings, not errors. * xamarin/maccore@84504ced5e Merge pull request dotnet#1814 from xamarin/swift-o-matic-fix-predicate * xamarin/maccore@82000e1a63 [submission] Fix makefile and clarify README (dotnet#1805) * xamarin/maccore@d0ebe3b175 Remove stale predicate. * xamarin/maccore@de6143449a Merge pull request dotnet#1806 from xamarin/swift-o-matic-c-structs * xamarin/maccore@e10ef79504 C struct exceptions * xamarin/maccore@a272402c7c Add the developerid required to run the notarization tests (dotnet#1804) * xamarin/maccore@747c18c482 Merge pull request dotnet#1803 from xamarin/swift-o-matic-date-nuance * xamarin/maccore@716082fd5e Moved string constants to SwiftFoundationConstants * xamarin/maccore@f250ca5418 Merge pull request dotnet#1799 from xamarin/swift-o-matic-date * xamarin/maccore@4d9a764e90 Basic support for Foundation.Date * xamarin/maccore@5ef84bc50c Merge pull request dotnet#1795 from xamarin/swift-o-matic-ctor-finding * xamarin/maccore@0899c35771 Demote error to warning. * xamarin/maccore@ba80294413 Drop the mono-extensions dependency. (dotnet#1789) * xamarin/maccore@ca616ef842 Merge pull request dotnet#1793 from xamarin/swift-o-matic-spring-fwk * xamarin/maccore@f0cd48c28c Fix name conflict * xamarin/maccore@beef68bf1e Merge pull request dotnet#1792 from xamarin/swift-o-matic-demangle-static * xamarin/maccore@558b62da62 typo * xamarin/maccore@5905981ad5 Added existential metatype * xamarin/maccore@ed7d4b8b19 Merge pull request dotnet#1784 from xamarin/swift-o-matic-bound-generics * xamarin/maccore@84f0bed939 Promote bound generics in closures to warnings, not errors. Diff: https://github.com/xamarin/maccore/compare/348833cb21c75ce1e82b477f405c8ef4bed9812c..809b2def3933d59811c3761e55c64351be94f6d3

This is in part so we get xamarin/maccore#1924 -> [mlaunch] Connect to devices on a background thread. That should hopefully fix device not found issues we're having on some bots/ New commits in xamarin/macios-binaries: * xamarin/macios-binaries@01d34af Bump mlaunch to xamarin/maccore@809b2def39 (#24) Diff: https://github.com/xamarin/macios-binaries/compare/b474fa2e732974fde2edbfe054f23c5eefd0255b..01d34af6b03e81cefbb30d964e58fca66da86c4a New commits in xamarin/maccore: * xamarin/maccore@809b2def39 [mlaunch] Connect to devices on a background thread. (#1778) (#1924) * xamarin/maccore@5215c09e8c Merge pull request #1923 from xamarin/swift-o-matic-hello-protocol-list-type * xamarin/maccore@21447e2538 I. Can't. Believe. I'm. Checking. This. In. * xamarin/maccore@da6518f920 Added ProtocolListTypeSpec * xamarin/maccore@a9b9a0f5b3 Merge pull request #1920 from xamarin/swift-o-matic-bye-swift-protocol * xamarin/maccore@01e9420598 Lose all the SwiftProtocol related types. * xamarin/maccore@ca3bd0ab5b Merge pull request #1919 from xamarin/swift-redo-regular-protocols * xamarin/maccore@f534abee12 Now with existential containers * xamarin/maccore@9e180a823a Merge pull request #1911 from xamarin/swift-o-matic-string-convertible * xamarin/maccore@9874985856 Typo * xamarin/maccore@26731ff5cb Next step in Protocol revamp * xamarin/maccore@9fe4cdd652 Merge pull request #1904 from xamarin/swift-o-matic-hashable * xamarin/maccore@a1cd988dda iOS include * xamarin/maccore@f1fc694da6 Revamped hashable. * xamarin/maccore@16a6629a43 Merge pull request #1902 from xamarin/swift-o-matic-comparable * xamarin/maccore@a98db5b976 Dead symbol, changed symbol. * xamarin/maccore@3c38895694 Reworked Swift.Comparable to be defined in terms of EveryProtocol * xamarin/maccore@ef1d3c1397 Merge pull request #1895 from xamarin/swift-o-matic-equatable * xamarin/maccore@1c1a57fa4f Try again and get all the files, thanks. * xamarin/maccore@ec0a5b99b7 Revised EveryProtocol, updated Equatable * xamarin/maccore@198a489387 Simplified EveryProtocol, revised Equatable * xamarin/maccore@ee7710a186 Merge pull request #1894 from xamarin/swift-o-matic-every-protocol * xamarin/maccore@4fc0810fd2 Let's not leak memory, OK? * xamarin/maccore@451c0ba18d Try a little dispose magic. * xamarin/maccore@864854e407 Minor tweak to public API * xamarin/maccore@052990af11 Adding in EveryProtocol object * xamarin/maccore@b7f1347fcf Merge pull request #1893 from xamarin/swift-o-matic-protocol-binding * xamarin/maccore@df4aefe447 no swap files, vi. * xamarin/maccore@1e6bf8d4ef Merge pull request #1892 from xamarin/swift-o-matic-protocol-binding * xamarin/maccore@e46a543544 Typo * xamarin/maccore@fea9514c69 Let's document! * xamarin/maccore@9b5ecdfdce Merge pull request #1890 from xamarin/swift-o-matic-fail-on-wrong-version * xamarin/maccore@0b4afae5f3 Put in a hard fail on compiler version mismatch errors. * xamarin/maccore@d1475a43d1 Merge pull request #1881 from xamarin/swift-o-matic-NRE * xamarin/maccore@900e453695 Fixes and NRE from SCLAlertView * xamarin/maccore@0164c0ae83 Merge pull request #1873 from xamarin/swift-o-matic-README * xamarin/maccore@211b05a515 READMEs for errors, reminder to check README and associated issues in Makefile * xamarin/maccore@74650bf3f8 [SoM] Add '/usr/lib/swift' as an rpath before any other rpaths. (#1857) * xamarin/maccore@73dd23d00b Merge pull request #1859 from xamarin/swift-o-matic-SwiftLocation * xamarin/maccore@6704604de1 Add SwiftLocation * xamarin/maccore@e96ab505d8 Merge pull request #1855 from xamarin/swift-o-matic-bye-bye-dormant-3rd-party * xamarin/maccore@c17c506738 Remove dormant 3rd Party Tests * xamarin/maccore@366e201f11 Merge pull request #1854 from xamarin/swift-o-matic-update-3rd-party * xamarin/maccore@da748a9a1d Updated makefiles for projects that have updated to Swift 4.2 or > * xamarin/maccore@2e371bdaf2 Merge pull request #1849 from xamarin/swift-o-matic-gentler-errors * xamarin/maccore@921c21251d Lighten up on errors, get paper-switch * xamarin/maccore@f4fc280efe Merge pull request #1844 from xamarin/swift-o-matic-lottie * xamarin/maccore@e47aa6b50c Adding lottie-ios * xamarin/maccore@cf09fd4c59 [SoM] Copy swift libraries to foo.app/Frameworks for non-macOS apps. (#1842) * xamarin/maccore@a4af9cdd2d Merge pull request #1841 from xamarin/swift-o-matic-gentler-skip * xamarin/maccore@fc7cd38f64 [SoM] Handle the new BuildVersion load command. (#1827) * xamarin/maccore@8666e81b7d Ha-ha! When you make errors become warnings, tests that depend on errors change. * xamarin/maccore@e42a8c394f continue... * xamarin/maccore@3b0d6bc0e6 [SoM] Don't duplicate the nuget version number. (#1838) * xamarin/maccore@143afaf991 [msbuild] No need to use a shell function to resolve a relative path in make. (#1839) * xamarin/maccore@cbe86e0152 [SoM] Add a helpful make target to create a nuget and setup a local feed repository for it. (#1837) * xamarin/maccore@cfaaf1c5a5 [SoM] Enable swift's Stable ABI. (#1836) * xamarin/maccore@79166d9755 Made errors more lenient, added Hue framework. * xamarin/maccore@f4b0feeb55 Merge pull request #1830 from xamarin/swift-o-matic-prop-closure * xamarin/maccore@a14198fdee whitespace * xamarin/maccore@285874eceb handle ()->() and ()->type properly * xamarin/maccore@4785afe4ea Handle closures as return values. * xamarin/maccore@e89b80ca53 [SoM] Don't redownload the swift toolchain if we already have the file. (#1825) * xamarin/maccore@217a608e72 [SoM] Improve installed scripts. (#1826) * xamarin/maccore@ff283225b6 [SoM] Fix typo in type name. (#1824) * xamarin/maccore@189ea0cba7 Merge pull request #1818 from xamarin/swift-o-matic-SwiftMessages-NRE * xamarin/maccore@937541e0a6 restore back original code. * xamarin/maccore@30be8a354a continue on null * xamarin/maccore@dfceb83692 Merge pull request #1816 from xamarin/swift-o-matic-warn-not-fail * xamarin/maccore@b32e33e71d Make warnings, not errors. * xamarin/maccore@84504ced5e Merge pull request #1814 from xamarin/swift-o-matic-fix-predicate * xamarin/maccore@82000e1a63 [submission] Fix makefile and clarify README (#1805) * xamarin/maccore@d0ebe3b175 Remove stale predicate. * xamarin/maccore@de6143449a Merge pull request #1806 from xamarin/swift-o-matic-c-structs * xamarin/maccore@e10ef79504 C struct exceptions * xamarin/maccore@a272402c7c Add the developerid required to run the notarization tests (#1804) * xamarin/maccore@747c18c482 Merge pull request #1803 from xamarin/swift-o-matic-date-nuance * xamarin/maccore@716082fd5e Moved string constants to SwiftFoundationConstants * xamarin/maccore@f250ca5418 Merge pull request #1799 from xamarin/swift-o-matic-date * xamarin/maccore@4d9a764e90 Basic support for Foundation.Date * xamarin/maccore@5ef84bc50c Merge pull request #1795 from xamarin/swift-o-matic-ctor-finding * xamarin/maccore@0899c35771 Demote error to warning. * xamarin/maccore@ba80294413 Drop the mono-extensions dependency. (#1789) * xamarin/maccore@ca616ef842 Merge pull request #1793 from xamarin/swift-o-matic-spring-fwk * xamarin/maccore@f0cd48c28c Fix name conflict * xamarin/maccore@beef68bf1e Merge pull request #1792 from xamarin/swift-o-matic-demangle-static * xamarin/maccore@558b62da62 typo * xamarin/maccore@5905981ad5 Added existential metatype * xamarin/maccore@ed7d4b8b19 Merge pull request #1784 from xamarin/swift-o-matic-bound-generics * xamarin/maccore@84f0bed939 Promote bound generics in closures to warnings, not errors. Diff: https://github.com/xamarin/maccore/compare/348833cb21c75ce1e82b477f405c8ef4bed9812c..809b2def3933d59811c3761e55c64351be94f6d3

Add mmp support for AOT options in XS

1fa9c8c

dnfclas added the cla-already-signed label Mar 2, 2017

spouliot suggested changes Mar 2, 2017

View reviewed changes

Change variable names for the different aot fields

8db431e

spouliot approved these changes Mar 3, 2017

View reviewed changes

dalexsoto approved these changes Mar 3, 2017

View reviewed changes

Missed changing xamarin.mac.common.targets

82f6117

spouliot requested a review from jstedfast March 3, 2017 22:16

jstedfast approved these changes Mar 4, 2017

View reviewed changes

VincentDondain approved these changes Mar 9, 2017

View reviewed changes

timrisi merged commit 1f81d9d into dotnet:master Mar 17, 2017

VincentDondain mentioned this pull request Aug 21, 2019

Bump maccore and macios-binaries #6820

Merged

Add mmp support for AOT options in XS #1818

Add mmp support for AOT options in XS #1818

Uh oh!

Conversation

timrisi commented Mar 2, 2017

Uh oh!

spouliot Mar 2, 2017

Choose a reason for hiding this comment

Uh oh!

VincentDondain Mar 3, 2017

Choose a reason for hiding this comment

Uh oh!

timrisi Mar 3, 2017

Choose a reason for hiding this comment

Uh oh!

timrisi commented Mar 2, 2017

Uh oh!

monojenkins commented Mar 2, 2017

Uh oh!

spouliot commented Mar 3, 2017

Uh oh!

spouliot commented Mar 3, 2017

Uh oh!

VincentDondain commented Mar 3, 2017

Uh oh!

timrisi commented Mar 3, 2017

Uh oh!

VincentDondain commented Mar 3, 2017

Uh oh!

VincentDondain commented Mar 3, 2017

Uh oh!

monojenkins commented Mar 3, 2017

Uh oh!

monojenkins commented Mar 3, 2017

Uh oh!

timrisi commented Mar 16, 2017

Uh oh!

spouliot commented Mar 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants