Skip to content

Conversation

@marek-safar
Copy link
Contributor

No description provided.

…_5[_1] (#1518)"

This reverts commit e72b654.

because it's no longer needed with latest mono
@spouliot
Copy link
Contributor

https://bugzilla.xamarin.com/show_bug.cgi?id=53481 is presently blocking QA to complete testing

@monojenkins
Copy link
Collaborator

Build failure

@spouliot
Copy link
Contributor

@kzu @josegallardo @emaf I have not heard any comment / go ahead on the msbuild parts. A quick thumb up would be appreciated. thanks!

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

@rolfbjarne
Copy link
Member

build

@monojenkins
Copy link
Collaborator

Build failure

Copy link
Contributor

@emaf emaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The msbuild changes look good to me

Copy link
Contributor

@kzu kzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfbjarne @spouliot the PR looks fine. We'll just need to delete the PDB2MDB stuff on our side. I assume this will also be the case for XA, @jonpryor?

This basically means we'll likely be able to remove altogether the windows-only targets that XVS installs, I hope.

We'll adapt our side once this is merged.

Thanks and sorry for the delay!

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

1 similar comment
@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

@monojenkins
Copy link
Collaborator

Build failure

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved for merging.
Remaining issues to be solved afterward.

@spouliot spouliot merged commit 743c28f into master Mar 29, 2017
@monojenkins
Copy link
Collaborator

Build failure

@mandel-macaque mandel-macaque deleted the mono-2017-02 branch December 7, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enable-device-build Makes our build include device support (which we disable for simple PRs to speed them up) requires-approval-before-merge The pull request requires special approval before it can be merged requires-qa-before-merge The pull request requires QA to approve it before it can be merged run-all-tests Run all our tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.