Backport fixes for #51423: NSUrlSessionHandler cancellation issues #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2017 10:12
…SUrlSessionHandler. Fixes #51423 (dotnet#1888) Do pass the cancelation token in the NSUrlSessionHandler to ensure that if the request is cancelled we do not hang for ever. https://bugzilla.xamarin.com/show_bug.cgi?id=51423
…SessionTask (dotnet#1900) If the request is canceled, the inflight data is cleaned up. That allows us to know that the NSUrlSessionTask should be canceled, which will execute the DidCompleteWithError that will take care of the cleanup of resources and will ensure that everything is back to a known situation. * Do check for managed cancelations in the GetInflightData so that it is check in all handlers.
Collaborator
|
Build success |
Contributor
Author
|
Identical to PR 1900 and PR 1904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11258ee (Manuel de la Pena, 18 hours ago)
[Foundation] Ensure that if a request is canceled we cancel the
NSUrlSessionTask (#1900)
If the request is canceled, the inflight data is cleaned up. That allows us
to know that the NSUrlSessionTask should be canceled, which will execute
the DidCompleteWithError that will take care of the cleanup of resources
and will ensure that everything is back to a known situation.
check in all handlers.
5706a6b (Manuel de la Pena, 2 days ago)
[foundation] Honor the cancellation token win the async requests in
NSUrlSessionHandler. Fixes #51423 (#1888)
Do pass the cancelation token in the NSUrlSessionHandler to ensure that if
the request is cancelled we do not hang for ever.
https://bugzilla.xamarin.com/show_bug.cgi?id=51423