[devops] Rework how we hide GitHub comments. by rolfbjarne · Pull Request #21320 · dotnet/macios

rolfbjarne · 2024-09-27T15:06:56Z

Whenever we add a GitHub comment, also provide a comment id.
When adding a GitHub comment, use that comment id to hide any previous
comments with the same id.

It turns out this simplifies the code a lot, and additionally we now correctly
hide every comment we report whenever a step or stage is re-executed.

* Whenever we add a GitHub comment, also provide a comment id. * When adding a GitHub comment, use that comment id to hide any previous comments with the same id. It turns out this simplifies the code a lot, and additionally we now correctly hide every comment we report whenever a step or stage is re-executed.

rolfbjarne · 2024-09-30T07:14:50Z

/azp run

azure-pipelines · 2024-09-30T07:15:23Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-09-30T08:56:22Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dc1c637ea67a82288ab57d9b0913d3d20baa6f38 [PR build]

[comment]: <> (This is a comment added by Azure DevOps, id: macOS X64 - Mac Sonoma (14))

vs-mobiletools-engineering-service2 · 2024-09-30T08:58:56Z

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11) failed ❌

Failed tests are:

linksdk

Pipeline on Agent
Hash: dc1c637ea67a82288ab57d9b0913d3d20baa6f38 [PR build]

[comment]: <> (This is a comment added by Azure DevOps, id: macOS M1 - Mac Big Sur (11))

vs-mobiletools-engineering-service2 · 2024-09-30T08:59:57Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dc1c637ea67a82288ab57d9b0913d3d20baa6f38 [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T09:00:42Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dc1c637ea67a82288ab57d9b0913d3d20baa6f38 [PR build]

[comment]: <> (This is a comment added by Azure DevOps, id: macOS M1 - Mac Ventura (13))

…k-comment-hiding

vs-mobiletools-engineering-service2 · 2024-09-30T19:41:26Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T19:58:22Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T20:04:10Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T20:05:10Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T20:05:48Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T20:09:27Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-09-30T21:00:49Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 97 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T11:31:22Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 1d6e5ac997c2580067beddaccabcdafeb134bfdd [PR build]

* Whenever we add a GitHub comment, also provide a comment id. * When adding a GitHub comment, use that comment id to hide any previous comments with the same id. It turns out this simplifies the code a lot, and additionally we now correctly hide every comment we report whenever a step or stage is re-executed.

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review September 30, 2024 14:37

rolfbjarne added 2 commits September 30, 2024 20:16

Sanitize ID.

bb708fb

Merge remote-tracking branch 'origin/main' into dev/rolf/devops-rewor…

1d6e5ac

…k-comment-hiding

This comment has been minimized.

Sign in to view

stephen-hawley approved these changes Sep 30, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

dalexsoto approved these changes Sep 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 8831011 into main Oct 1, 2024

rolfbjarne deleted the dev/rolf/devops-rework-comment-hiding branch October 1, 2024 12:44

Conversation

rolfbjarne commented Sep 27, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Sep 30, 2024

Uh oh!

azure-pipelines Bot commented Sep 30, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

❌ [CI Build] Tests on macOS M1 - Mac Big Sur (11) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 30, 2024

📚 [CI Build] Artifacts 📚

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Sep 30, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vs-mobiletools-engineering-service2 commented Sep 30, 2024 •

edited by rolfbjarne

Loading