[dotnet] Don't link with BrowserEngineKit. Fixes #21324. by rolfbjarne · Pull Request #21337 · dotnet/macios

rolfbjarne · 2024-09-30T19:29:25Z

github-actions · 2024-09-30T19:33:03Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2024-10-01T10:20:29Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-10-01T10:43:31Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T08:09:52Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 97 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T10:33:32Z

✅ API diff for current PR / commit

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T14:31:15Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T14:33:18Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T14:33:52Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-02T14:35:47Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 065d49ec1c70f6feb64daba3de8025f7a5425da4 [PR build]

rolfbjarne · 2024-10-02T17:54:58Z

/sudo backport release/8.0.1xx-xcode16.0

rolfbjarne · 2024-10-02T17:55:04Z

/sudo backport net9.0

vs-mobiletools-engineering-service2 · 2024-10-02T17:55:54Z

Backport Job to branch release/8.0.1xx-xcode16.0 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-10-02T17:56:01Z

Backport Job to branch net9.0 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-10-02T17:58:25Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10320252 for more details.

vs-mobiletools-engineering-service2 · 2024-10-02T17:58:32Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10320253 for more details.

Backport of #21337. Fixes #21324.

…1360) Backport of #21337. Fixes #21324.

…Fixes #21324. (#21359) Fixes #21324. Backport of #21337 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

rolfbjarne and others added 2 commits September 30, 2024 21:21

[dotnet] Don't link with BrowserEngineKit. Fixes #21324.

7cf9eec

Fixes #21324.

Auto-format source code

e02ce18

stephen-hawley approved these changes Sep 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

drasticactions mentioned this pull request Oct 1, 2024

MAUI iOS Publish to AppStore: Rejected because of BrowserEngineKit in use dotnet/maui#24980

Closed

rolfbjarne added 2 commits October 1, 2024 10:42

Introspection should link with BrowserEngineKit.

3374362

Merge remote-tracking branch 'origin/main' into dev/rolf/issue-21324

065d49e

This comment has been minimized.

Sign in to view

mcumming approved these changes Oct 2, 2024

View reviewed changes

rolfbjarne merged commit f6501e9 into main Oct 2, 2024

rolfbjarne deleted the dev/rolf/issue-21324 branch October 2, 2024 17:54

vs-mobiletools-engineering-service2 mentioned this pull request Oct 2, 2024

[release/8.0.1xx-xcode16.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324. #21359

Merged

rolfbjarne added a commit that referenced this pull request Oct 2, 2024

[net9.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324.

4669434

Backport of #21337. Fixes #21324.

rolfbjarne mentioned this pull request Oct 2, 2024

[net9.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324. #21360

Merged

rolfbjarne added a commit that referenced this pull request Oct 3, 2024

[net9.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324. (#2…

732d606

…1360) Backport of #21337. Fixes #21324.

rolfbjarne added a commit that referenced this pull request Oct 4, 2024

[release/8.0.1xx-xcode16.0] [dotnet] Don't link with BrowserEngineKit. …

13390b4

…Fixes #21324. (#21359) Fixes #21324. Backport of #21337 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Conversation

rolfbjarne commented Sep 30, 2024

Uh oh!

github-actions Bot commented Sep 30, 2024

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 1, 2024

📚 [CI Build] Artifacts 📚

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 1, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 2, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

rolfbjarne commented Oct 2, 2024

Uh oh!

rolfbjarne commented Oct 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants