Skip to content

[net9.0] [UIKit] Improve code for UISegmentedControl. Fixes #21289.#21345

Merged
rolfbjarne merged 5 commits intonet9.0from
backport-pr-21299-to-net9.0
Oct 2, 2024
Merged

[net9.0] [UIKit] Improve code for UISegmentedControl. Fixes #21289.#21345
rolfbjarne merged 5 commits intonet9.0from
backport-pr-21299-to-net9.0

Conversation

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

  1. Enable nullability.
  2. Move Get|SetTitleTextAttributes to generated code.
  3. Remove dead code (pre-.NET code paths).

Point 2. fixes #21289, so add tests for this scenario.

Fixes #21289.

Backport of #21299

1. Enable nullability.
2. Move Get|SetTitleTextAttributes to generated code.
3. Remove dead code (pre-.NET code paths).

Point 2. fixes #21289, so add tests for this scenario.

Fixes #21289.
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 99 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 61081fc08365142d71ee762c02e95636315fc1b4 [PR build]

@rolfbjarne rolfbjarne merged commit ad8352f into net9.0 Oct 2, 2024
@rolfbjarne rolfbjarne deleted the backport-pr-21299-to-net9.0 branch October 2, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants