Skip to content

[tests] Fix FontManagerTest.RegisterFontDescriptors_WithCallback to be a bit more lax. Fixes #6690. #21348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 3 commits into from
Oct 3, 2024
Merged

[tests] Fix FontManagerTest.RegisterFontDescriptors_WithCallback to be a bit more lax. Fixes #6690. #21348

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c32288
[tests] Fix FontManagerTest.RegisterFontDescriptors_WithCallback to b…
rolfbjarne Oct 1, 2024
a6b2387
Auto-format source code
Oct 1, 2024
9033e06
Merge branch 'main' into dev/rolf/issue-6690
rolfbjarne Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions tests/monotouch-test/CoreText/FontManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ public void UnregisterFontDescriptors_Null ()
Assert.Throws<ArgumentException> (() => CTFontManager.UnregisterFontDescriptors (new CTFontDescriptor [] { null }, CTFontManagerScope.Process, null), "null element");
}

#if !__WATCHOS__
[Test]
public void RegisterFontDescriptors_NoCallback ()
{
Expand All @@ -205,11 +204,6 @@ public void RegisterFontDescriptors_NoCallback ()
}
}

#if __TVOS__
[Ignore ("Fails on tvOS with undocumented error code 'The operation couldn’t be completed. (com.apple.CoreText.CTFontManagerErrorDomain error 500.'")]
#elif __IOS__
[Ignore ("https://github.com/xamarin/xamarin-macios/issues/6690. This began failing for no aparent reason in iOS 13 Beta 5. Check back with GM.")]
#endif
[Test]
public void RegisterFontDescriptors_WithCallback ()
{
Expand All @@ -220,13 +214,30 @@ public void RegisterFontDescriptors_WithCallback ()
StyleName = "Bold",
Size = 16.0f
};
Exception? ex = null;
using (CTFontDescriptor fd = new CTFontDescriptor (fda)) {
var array = new [] { fd };
CTFontManager.RegisterFontDescriptors (array, CTFontManagerScope.Process, true, SuccessDone);
CTFontManager.UnregisterFontDescriptors (array, CTFontManagerScope.Process, SuccessDone);
CTFontManager.RegisterFontDescriptors (array, CTFontManagerScope.Process, true, (NSError [] errors, bool done) => {
try {
Assert.True (done, "done: RegisterFontDescriptors");
} catch (Exception e) {
ex = e;
}
return true;
});
Assert.That (ex, Is.Null.Or.Not.Null, "RegisterFontDescriptors");

CTFontManager.UnregisterFontDescriptors (array, CTFontManagerScope.Process, (NSError [] errors, bool done) => {
try {
Assert.True (done, "done: UnregisterFontDescriptors");
} catch (Exception e) {
ex = e;
}
return true;
});
Assert.That (ex, Is.Null.Or.Not.Null, "UnregisterFontDescriptors");
}
}
#endif

[Test]
public void GetFontsNullUrl ()
Expand Down