Skip to content

[release/8.0.1xx-xcode16.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324. #21359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 4 commits into from
Oct 4, 2024
Merged

[release/8.0.1xx-xcode16.0] [dotnet] Don't link with BrowserEngineKit. Fixes #21324. #21359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30e4dae
[dotnet] Don't link with BrowserEngineKit. Fixes #21324.
rolfbjarne Sep 30, 2024
9a41ed8
Auto-format source code
Sep 30, 2024
fea53b0
Introspection should link with BrowserEngineKit.
rolfbjarne Oct 1, 2024
297fd83
Merge branch 'release/8.0.1xx-xcode16.0' into backport-pr-21337-to-re…
rolfbjarne Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,11 @@
<!-- libSystem.Security.Cryptography.Native.Apple.a requires the Security framework -->
<_NativeExecutableFrameworks Include="Security" />

<!-- Most apps do not use BrowserEngineKit, and linking with it when an app is not supposed to will prevent it from getting approved in the App Store.
However, we'll automatically detect that we need to link with BrowserEngineKit if an app isn't trimmed, so let's just remove BrowserEngineKit
here, with an escape hatch if an app really needs it (which would be rather rare). Ref: https://github.com/xamarin/xamarin-macios/issues/21324 -->
<_NativeExecutableFrameworks Remove="BrowserEngineKit" Condition="'$(LinkWithBrowserEngineKit)' != 'true'" />

<!-- Mono requires zlib, iconv, and the "Compression framework" -->
<_MainLinkerFlags Include="-lz" />
<_MainLinkerFlags Include="-liconv" />
Expand Down
Loading