[RGen] First inclusion of a roslyn generator for the bindings. by mandel-macaque · Pull Request #21389 · dotnet/macios

mandel-macaque · 2024-10-08T19:45:44Z

We are doing the following:

Adding the rgen directory with the following solutions:
- Analyzer: Analyzer that will catch errors in the bindings. At the moment it provides a single error when the BindingTypeAttribute is used in a nont partial type.
- Analyzer Tests: Allows tests for the analyzer.
- Analyzer Sample: Sample project to test the analyzer.
- Code Generator: A code generator that adds the BindingTypeAttribute to the compilcation.
- Code Generator Tests: Allows tests for the generator.
- Code Sample: Sample project for the code generator.
Make rule to build the roslyn code generator.
Makefile changes to add the code generator as part as the second compilation of the bindings.

This changes add the starting gounds to move to roslyn.

We are doing the following: 1. Adding the rgen directory with the following solutions: * Analyzer: Analyzer that will catch errors in the bindings. At the moment it provides a single error when the BindingTypeAttribute is used in a nont partial type. * Analyzer Tests: Allows tests for the analyzer. * Analyzer Sample: Sample project to test the analyzer. * Code Generator: A code generator that adds the BindingTypeAttribute to the compilcation. * Code Generator Tests: Allows tests for the generator. * Code Sample: Sample project for the code generator. 2. Make rule to build the roslyn code generator. 3. Makefile changes to add the code generator as part as the second compilation of the bindings. This changes add the starting gounds to move to roslyn.

github-actions · 2024-10-08T19:49:35Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2024-10-08T19:50:41Z

+	protected CSharpGeneratorDriver _driver;
+	protected PortableExecutableReference [] _references;
+	// HACK: this is a hack to get the runtime dll for the attributes
+	const string RuntimeDll = "/Users/mandel/Xamarin/xamarin-macios/xamarin-macios/src/build/dotnet/ios/64/Microsoft.iOS.dll";


Ugh, I need to fix this for the tests. @haritha-mohan can you do the same trick you do with adr here?

rolfbjarne

The tests should be executed when the generator/bgen tests are executed in xharness as well.

rolfbjarne · 2024-10-09T06:40:02Z

@@ -0,0 +1,26 @@
+/*


Either remove or uncomment/fix.

rolfbjarne · 2024-10-09T06:40:23Z

@@ -0,0 +1,32 @@
+/*


Either remove or uncomment/fix.

rolfbjarne · 2024-10-09T06:41:12Z

+/// A sample code fix provider that renames classes with the company name in their definition.
+/// All code fixes must  be linked to specific analyzers.


This comment is out of date.

rolfbjarne

The tests should be executed when the generator/bgen tests are executed in xharness as well.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2024-10-10T00:09:23Z

🔥 [CI Build] Build failed 🔥

Build failed for the job 'Build packages'

Pipeline on Agent
Hash: cbeddc34fef102fa66bdf6cdea9dffda8ae9d6aa [PR build]

1. Allow the tests to use the compiled dlls for dotnet. 2. Added an example test for the code generator. 3. Added an example test for the analyzer. 4. Included the new test projects in xharness.

…arin-macios into dev/mandel/rgen-init-project

vs-mobiletools-engineering-service2 · 2024-10-15T15:40:06Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:47:58Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:54:27Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:56:15Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T15:58:08Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

vs-mobiletools-engineering-service2 · 2024-10-15T18:15:46Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 100 tests passed.

Failures

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

Details

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: dcd362b1ff3fe6b120c9f16958ad2ed5f6e8dc2a [PR build]

We are doing the following: 1. Adding the rgen directory with the following solutions: * Analyzer: Analyzer that will catch errors in the bindings. At the moment it provides a single error when the BindingTypeAttribute is used in a nont partial type. * Analyzer Tests: Allows tests for the analyzer. * Analyzer Sample: Sample project to test the analyzer. * Code Generator: A code generator that adds the BindingTypeAttribute to the compilcation. * Code Generator Tests: Allows tests for the generator. * Code Sample: Sample project for the code generator. 2. Make rule to build the roslyn code generator. 3. Makefile changes to add the code generator as part as the second compilation of the bindings. This changes add the starting gounds to move to roslyn. --------- Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Alex Soto <alex@soto.dev>

mandel-macaque requested a review from rolfbjarne as a code owner October 8, 2024 19:45

Auto-format source code

ad8c2cb

mandel-macaque commented Oct 8, 2024

View reviewed changes

Merge branch 'main' into dev/mandel/rgen-init-project

e25bb24

mandel-macaque commented Oct 8, 2024

View reviewed changes

Comment thread src/Makefile Outdated

Update src/Makefile

5b21411