Skip to content

[msbuild] Make sure the build doesn't keep going if the ILLink task fails. #21393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Oct 16, 2024
Merged

[msbuild] Make sure the build doesn't keep going if the ILLink task fails. #21393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea87c3e
[msbuild] Make sure the build doesn't keep going if the ILLink task f…
rolfbjarne Oct 9, 2024
15c7742
Merge remote-tracking branch 'origin/main' into dev/rolf/illink-failure
rolfbjarne Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,10 @@ Copyright (C) 2011-2013 Xamarin. All rights reserved.
<Output TaskParameter="LinkerOutputItems" ItemName="_XamarinLinkerItems" />
</Xamarin.MacDev.Tasks.ILLink>

<PropertyGroup>
<!-- Sometimes the ILLink task itself fails, in which case the _ILLinkExitCode value won't be set. In this case, set it to a value that will cause the expected error to be shown later on. -->
Copy link
Copy Markdown
Contributor

@stephen-hawley stephen-hawley Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is the case? Does ILLink need a fix and if so, is there an issue for it?

Copy link
Copy Markdown
Member Author

@rolfbjarne rolfbjarne Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are any number of reasons the ILLink task may fail for legitimate reasons, an easy one being that the network went down.

<_ILLinkExitCode Condition="'$(_ILLinkExitCode)' == '' And '$(MSBuildLastTaskResult)' != 'true'">-1</_ILLinkExitCode>
</PropertyGroup>
<Touch Files="$(_LinkSemaphore)" AlwaysCreate="true" Condition=" '$(_ILLinkExitCode)' == '0' " />

</Target>
Expand Down