[devops] Stop provisioning Mono. by rolfbjarne · Pull Request #21411 · dotnet/macios

rolfbjarne · 2024-10-10T14:49:55Z

Current known blockers:

xtro-sharpie must be executed using Mono, since it loads a native library that needs Mono.

It's not needed during our build anymore.

mandel-macaque · 2024-10-10T18:14:23Z

You probably need to remove the use of the cache in the yml file that stored the mono download.

github-actions · 2024-10-10T18:14:55Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

stephen-hawley · 2024-10-10T18:17:08Z

 			install_mono
 			ACTUAL_MONO_VERSION=`cat $MONO_VERSION_FILE`
+		elif test -n "$OPTIONAL_MONO"; then
+			warn "It's recommended to have no higher than Mono $MAX_MONO_VERSION, found $ACTUAL_MONO_VERSION. Download URL: $MIN_MONO_URL"


I just want to say for the record that I love how if a resource isn't available that you direct the user where to download the right version.

…with .NET. Note that it's still executed with Mono, because we load a native library that needs Mono at runtime.

vs-mobiletools-engineering-service2 · 2024-10-16T09:12:33Z

🔥 Failed to compare API and create generator diff 🔥

Error: The system requirements for the hash to compare against (209de6f) are different than for the current hash. Comparison is currently not supported in this scenario.

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-16T09:50:08Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-16T09:53:47Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-16T09:54:29Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-16T09:55:25Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-16T11:20:07Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 3 tests failed, 96 tests passed.

Failures

❌ fsharp tests

1 tests failed, 3 tests passed.

Details

fsharp/iOS Unified 64-bits - simulator/Debug [dotnet]: HarnessException (Harness exception for 'fsharp': System.AggregateException: One or more errors occurred. (A task was canceled.)
---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
at System.Threading.Tasks.Task.GetExceptions(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.get_TestExecutionStarted() at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult() at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine) at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult() at Xharness.AppRunner.RunAsync() in /Users/builder/azdo/_work/7/s/xamarin-macios/tests/xharness/AppRunner.cs:line 453 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.ExecuteCommandAsync(String filename, IList1 args, ILog log, ILog stdout, ILog stderr, TimeSpan timeout, Dictionary2 environmentVariables, Nullable1 cancellationToken)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext()
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.RunAsyncInternal(Process process, ILog log, ILog stdout, ILog stderr, Action2 kill, Func3 getChildProcessIds, Nullable1 timeout, Dictionary2 environmentVariables, Nullable1 cancellationToken, Nullable1 diagnostics)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext()
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.WaitForExitAsync(Process process, Nullable1 timeout) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread) at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext() at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining) at System.Threading.Tasks.Task.RunContinuations(Object continuationObject) at Microsoft.DotNet.XHarness.Common.Utilities.Extensions.TimeoutAfter[T](Task1 task, TimeSpan timeout)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.ExecutionContextCallback(Object s)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext()
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(IAsyncStateMachineBox box, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at System.Threading.Tasks.Task1.TrySetResult(TResult result) at System.Threading.Tasks.Task.TwoTaskWhenAnyPromise1.Invoke(Task completingTask)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at System.Threading.Tasks.TaskCompletionSource1.TrySetResult(TResult result) at Microsoft.DotNet.XHarness.Common.Execution.ProcessManager.<>c__DisplayClass11_0.<WaitForExitAsync>g__ProcessExited|0(Object sender, EventArgs ea) at System.Diagnostics.Process.RaiseOnExited() at System.Diagnostics.Process.CompletionCallback(Object waitHandleContext, Boolean wasSignaled) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.PortableThreadPool.CompleteWait(RegisteredWaitHandle handle, Boolean timedOut) at System.Threading.ThreadPoolWorkQueue.Dispatch() at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() at System.Threading.Thread.StartCallback() --- End of stack trace from previous location --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions) at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)
at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.get_TestExecutionStarted()
at Microsoft.DotNet.XHarness.iOS.Shared.TestReporter.ParseResult()
at Xharness.AppRunner.RunAsync() in /Users/builder/azdo/_work/7/s/xamarin-macios/tests/xharness/AppRunner.cs:line 453
at Xharness.Jenkins.TestTasks.RunSimulator.RunTestAsync() in /Users/builder/azdo/_work/7/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/RunSimulator.cs:line 128
at Xharness.Jenkins.TestTasks.RunTest.ExecuteAsync() in /Users/builder/azdo/_work/7/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/RunTest.cs:line 113
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/7/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 245)

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

1 tests failed, 8 tests passed.

Details

monotouch-test/Mac [dotnet]/Debug (managed static registrar) [dotnet]: Failed (Test run failed.
Tests run: 3009 Passed: 2794 Inconclusive: 4 Failed: 1 Ignored: 214)

Html Report (VSDrops) Download

❌ xtro tests

1 tests failed, 0 tests passed.

Details

Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 765d5eb125c44f94fb3b4723469f21e1b1558933 [PR build]

rolfbjarne · 2024-11-04T12:36:26Z

Closing this and opening an issue for xtro port to .NET: #21573.

[devops] Stop provisioning Mono.

4ed5c03

It's not needed during our build anymore.

This comment has been minimized.

Sign in to view

[system-dependencies] Make Mono optional.

8144277

This comment has been minimized.

Sign in to view

rolfbjarne added 8 commits October 10, 2024 19:56

[csharp] Port the versions-check.csharp script to a .NET project.

794efff

[csharp] Port csharp scripts in src/ to .NET projects.

a7a046e

[csharp] Port csharp scripts in dotnet/ to .NET projects.

c139a22

[csharp] Port csharp scripts in tests/ to .NET projects.

db7dd76

sqgenerateerrors

71db0cb

sqsrc

d4ad674

sqtests

5b52d6f

Merge remote-tracking branch 'origin/main' into remove-mono-dependency

421853a

Auto-format source code

210ce59

stephen-hawley reviewed Oct 10, 2024

View reviewed changes

stephen-hawley approved these changes Oct 10, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

Step by step.

584e61b

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 11, 2024 12:08

Step by step, v2

c2f674a

Step by step, v3 - use ilrepack to sign instead of sn.

efc06ba

rolfbjarne added 2 commits October 15, 2024 15:10

Package a bit more.

beb8127

Remove more stuff.

0e843bb

This comment has been minimized.

Sign in to view

rolfbjarne added 4 commits October 15, 2024 17:36

Don't build in parallel, it pretty much fails all the time.

36b12c4

Package more.

a33f0d7

[devops] Install .NET on macOS bots.

e0f5fe9

Use system .NET.

e305433

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 16, 2024 10:15

Port to .NET

cc06189

[xtro] Port the xtro-sharpie.csproj to a new style project and build …

765d5eb

…with .NET. Note that it's still executed with Mono, because we load a native library that needs Mono at runtime.

rolfbjarne added the do-not-merge Do not merge this pull request label Oct 17, 2024

rolfbjarne mentioned this pull request Nov 4, 2024

Port xtro to use .NET instead of Mono #21573

Closed

rolfbjarne closed this Nov 4, 2024

Conversation

rolfbjarne commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Oct 10, 2024

Uh oh!

github-actions Bot commented Oct 10, 2024

⚠️ Your code has been reformatted. ⚠️

Uh oh!

stephen-hawley Oct 10, 2024

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 16, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 16, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 16, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 16, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 16, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 16, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ fsharp tests

❌ monotouch tests (macOS)

❌ xtro tests

Successes

Uh oh!

rolfbjarne commented Nov 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rolfbjarne commented Oct 10, 2024 •

edited

Loading