Skip to content

[main] [nuget-msi-convert] Support improved VS component IDs#21438

Merged
rolfbjarne merged 2 commits intomainfrom
backport-pr-21423-to-main
Oct 16, 2024
Merged

[main] [nuget-msi-convert] Support improved VS component IDs#21438
rolfbjarne merged 2 commits intomainfrom
backport-pr-21423-to-main

Conversation

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Oct 15, 2024

Context: dotnet/arcade@b2d3a3a
Context: https://github.com/xamarin/yaml-templates/pull/339

The VS insertion manifest generation has been updated to use new VS
component IDs required for .NET 9+.

Backport of #21423

@pjcollins
[nuget-msi-convert] Support improved VS component IDs
89186b2 
Context: dotnet/arcade@b2d3a3a
Context: xamarin/yaml-templates#339

The VS insertion manifest generation has been updated to use new VS
component IDs required for .NET 9+.
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 15, 2024

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 99 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 89186b2ed9bf3c8a65e0cd7852c4f6c7312edf6a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 14c674612f995c9ad67aa43626cb584a97882983 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 15, 2024

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 14c674612f995c9ad67aa43626cb584a97882983 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 14c674612f995c9ad67aa43626cb584a97882983 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 15, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 14c674612f995c9ad67aa43626cb584a97882983 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator Author

vs-mobiletools-engineering-service2 commented Oct 16, 2024

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 14c674612f995c9ad67aa43626cb584a97882983 [PR build]

@rolfbjarne rolfbjarne merged commit 9013ae4 into main Oct 16, 2024
@rolfbjarne rolfbjarne deleted the backport-pr-21423-to-main branch October 16, 2024 12:47
haritha-mohan pushed a commit that referenced this pull request Oct 19, 2024
@vs-mobiletools-engineering-service2 @pjcollins @haritha-mohan
[nuget-msi-convert] Support improved VS component IDs (#21438)
7706cbc 
Context: dotnet/arcade@b2d3a3a
Context: https://github.com/xamarin/yaml-templates/pull/339

The VS insertion manifest generation has been updated to use new VS
component IDs required for .NET 9+.

Backport of #21423

---------

Co-authored-by: Peter Collins <pecolli@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @pjcollins