[nuget-msi-convert] Do not use new VS component IDs by pjcollins · Pull Request #21476 · dotnet/macios

pjcollins · 2024-10-17T19:34:45Z

Context: 9013ae4

We've decided hold off on this change until .NET 10.

Context: 9013ae4 We've decided hold off on this change until .NET 10.

pjcollins · 2024-10-17T19:37:43Z

We'll need this in all .NET 9 branches where this prop was added and set to true.

dalexsoto · 2024-10-17T19:52:16Z

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

dalexsoto · 2024-10-17T19:52:53Z

We'll need this in all .NET 9 branches where this prop was added and set to true.

so we wil probably also need this in the net9.0 branch

vs-mobiletools-engineering-service2 · 2024-10-17T20:57:33Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-17T20:58:24Z

✅ API diff for current PR / commit

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-17T21:34:48Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-17T21:40:15Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

vs-mobiletools-engineering-service2 · 2024-10-17T21:41:28Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

rolfbjarne · 2024-10-18T15:30:05Z

/sudo backport net9.0

rolfbjarne · 2024-10-18T15:30:48Z

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

We'll have to re-apply the initial change in net10.0 once we've merged main into net10.0 the next time.

vs-mobiletools-engineering-service2 · 2024-10-18T15:32:18Z

Backport Job to branch net9.0 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-10-18T15:34:46Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10414173 for more details.

vs-mobiletools-engineering-service2 · 2024-10-18T17:08:25Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 101 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fb4ed76ad9102c6e1c121d1e48d153c16a06fc51 [PR build]

Context: dotnet/arcade@b2d3a3a Context: xamarin/yaml-templates#339 The VS insertion manifest generation has been updated to use new VS component IDs required for .NET 10+. Re-application of #21423 for .NET 10+. See also #21476. --------- Co-authored-by: Peter Collins <pecolli@microsoft.com>

rolfbjarne · 2024-10-21T08:24:51Z

@rolfbjarne / @pjcollins this is likely to be reverted if we are not careful with the main merges to our net10.0 branch

We'll have to re-apply the initial change in net10.0 once we've merged main into net10.0 the next time.

I've merged main into net10.0 (#21480), and re-applied the fix there (04f4de3)

Context: 9013ae4 We've decided hold off on this change until .NET 10. Backport of #21476 Co-authored-by: Peter Collins <pecolli@microsoft.com>

[nuget-msi-convert] Do not use new VS component IDs

fb4ed76

Context: 9013ae4 We've decided hold off on this change until .NET 10.

pjcollins requested review from dalexsoto and rolfbjarne October 17, 2024 19:37

This comment has been minimized.

Sign in to view

vs-mobiletools-engineering-service2 mentioned this pull request Oct 18, 2024

[net9.0] [nuget-msi-convert] Do not use new VS component IDs #21477

Merged

rolfbjarne approved these changes Oct 21, 2024

View reviewed changes

rolfbjarne merged commit d283463 into main Oct 21, 2024

rolfbjarne deleted the dev/pjc/revert-new-vsids branch October 21, 2024 08:17

Conversation

pjcollins commented Oct 17, 2024

Uh oh!

pjcollins commented Oct 17, 2024

Uh oh!

dalexsoto commented Oct 17, 2024

Uh oh!

dalexsoto commented Oct 17, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 17, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 17, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 17, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 17, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 17, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

rolfbjarne commented Oct 18, 2024

Uh oh!

rolfbjarne commented Oct 18, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 18, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 18, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 18, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants