Skip to content

[introspection] Numerous technical debt fixes.#21584

Merged
rolfbjarne merged 3 commits intomainfrom
dev/rolf/tests-introspection-technical-debt
Nov 7, 2024
Merged

[introspection] Numerous technical debt fixes.#21584
rolfbjarne merged 3 commits intomainfrom
dev/rolf/tests-introspection-technical-debt

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne commented Nov 6, 2024

  • Remove all legacy code.
  • Fix all warnings.
  • Enable warnings as errors.
  • Started unifying code between macOS vs iOS/tvOS/MacCatalyst.
  • Updated README slightly.

rolfbjarne and others added 3 commits November 6, 2024 10:15
@rolfbjarne
[introspection] Numerous technical debt fixes.
ac4cf30 
* Remove all legacy code.
* Fix all warnings.
* Enable warnings as errors.
* Started unifying code between macOS vs iOS/tvOS/MacCatalyst.
* Updated README slightly.
@rolfbjarne
Update autoformat script.
28462ff
Auto-format source code
a5daff7
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2024

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Nov 6, 2024

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 101 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a5daff7039a1982efffebde14d686dc5898bbf8a [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review November 6, 2024 19:58
stephen-hawley
stephen-hawley approved these changes Nov 6, 2024
View reviewed changes
Comment thread tests/common/AppDelegate.cs
using NUnit.Framework;
using NUnit.Framework.Internal;

// Disable until we get around to enable + fix any issues.
Copy link
Copy Markdown
Contributor

@stephen-hawley stephen-hawley Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for these?

Copy link
Copy Markdown
Member Author

@rolfbjarne rolfbjarne Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically #6154

@rolfbjarne rolfbjarne merged commit 49b837f into main Nov 7, 2024
@rolfbjarne rolfbjarne deleted the dev/rolf/tests-introspection-technical-debt branch November 7, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+1 more reviewer

@stephen-hawley stephen-hawley stephen-hawley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @stephen-hawley