Skip to content

[msbuild] Enable nullability in the ParseDeviceSpecificBuildInformation task. Fixes #22550.#22551

Merged
rolfbjarne merged 1 commit intomainfrom
dev/rolf/msbuild-parsedevicespecificbuildinformation
Apr 4, 2025
Merged

[msbuild] Enable nullability in the ParseDeviceSpecificBuildInformation task. Fixes #22550.#22551
rolfbjarne merged 1 commit intomainfrom
dev/rolf/msbuild-parsedevicespecificbuildinformation

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

Improve a few things in the ParseDeviceSpecificBuildInformation task:

  • Enable nullability.
  • Update code a bit to newer standards.
  • Don't pass 'SessionId' to the task, because it's not executed remotely anyways.

Fixes #22550.

…on task. Fixes #22550.

Improve a few things in the ParseDeviceSpecificBuildInformation task:

* Enable nullability.
* Update code a bit to newer standards.
* Don't pass 'SessionId' to the task, because it's not executed remotely anyways.

Fixes #22550.
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #0fd3648] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #0fd3648] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #0fd3648] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #0fd3648] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #0fd3648] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #0fd3648] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #0fd3648] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #0fd3648] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 124 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0fd3648bf616a2d6874999e36330e1d49b97ac1a [PR build]

@rolfbjarne rolfbjarne merged commit b773200 into main Apr 4, 2025
47 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/msbuild-parsedevicespecificbuildinformation branch April 4, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows build perf] ParseDeviceSpecificBuildInformation does not need to run remotely

4 participants