[RGen] Generate the argument syntax for the trampoline delegate call. #22764

mandel-macaque · 2025-05-08T14:51:57Z

Add a factory method that will generate the argument syntax for the parameters to be used in the delegate call within a trampoline.

There are several clases generated for a trampoline and we need the nomenclator to be able to generate the class names.

…ampoline class. There are 3 different types that are declared for a trampoline: 1. The delegate type. 2. The static bridge class. 3. The nativce invocation delegate class. When passing a delegate as a parameter for a delegate we need to pass the native inbocation delegate class. This new factory method generates the needed Create call expression syntax to use in the trampoline generation.

…factory-method-create-native-invocation-class

…cation-class

Add a factory method that will generate the argument syntax for the parameters to be used in the delegate call within a trampoline.

StephaneDelcroix · 2025-05-12T07:33:59Z

tests/rgen/Microsoft.Macios.Generator.Tests/NomenclatorTests.cs

 		public IEnumerator<object []> GetEnumerator ()
 		{
-			var exampleParameter = new Parameter (0, ReturnTypeForBool (), "firstParameter");
+			var exampleParameter = new DelegateParameter (0, ReturnTypeForBool (), "firstParameter");


for readability, you could name your integer parameters (like you do for bool)

Will do in an upcoming PR.

vs-mobiletools-engineering-service2 · 2025-05-12T16:27:15Z

✅ [CI Build #4837b53] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T16:29:22Z

✅ [PR Build #4837b53] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T16:55:20Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T16:58:28Z

✅ [CI Build #4837b53] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T17:14:18Z

💻 [CI Build #4837b53] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T17:17:05Z

💻 [CI Build #4837b53] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T17:18:14Z

💻 [CI Build #4837b53] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T17:20:22Z

💻 [CI Build #4837b53] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-12T18:57:20Z

🔥 [CI Build #4837b53] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 10 tests failed, 104 tests passed.

Failures

❌ monotouch tests (tvOS)

10 tests failed, 0 tests passed.

Details

monotouch-test/tvOS - simulator/Debug: Failed
monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
monotouch-test/tvOS - simulator/Debug (static registrar): Failed
monotouch-test/tvOS - simulator/Release (all optimizations): Failed
monotouch-test/tvOS - simulator/Debug (ARM64): Failed
monotouch-test/tvOS - simulator/Release (NativeAOT, ARM64): Failed
monotouch-test/tvOS - simulator/Debug (managed static registrar): Failed
monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations): Failed
monotouch-test/tvOS - simulator/Release (NativeAOT, x64): Failed
monotouch-test/tvOS - simulator/Debug (interpreter): Failed

Html Report (VSDrops) Download

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4837b53877d98b4e7531b0bf46adcdeb0e7452f4 [PR build]

mandel-macaque · 2025-05-13T15:20:37Z

Failing tests are unrelated to code changes.

mandel-macaque and others added 11 commits May 6, 2025 16:06

[RGen] Add support for class naming for the trampolines.

2151a1d

There are several clases generated for a trampoline and we need the nomenclator to be able to generate the class names.

Auto-format source code

11539ab

Correctly access the static method.

8efa1ce

Auto-format source code

ad3084c

Merge branch 'main' into dev/mandel/trampoline-name-class-type

4ddf07c

Merge branch 'dev/mandel/trampoline-name-class-type' into dev/mandel/…

ee459ed

…factory-method-create-native-invocation-class

Merge branch 'main' into dev/mandel/trampoline-name-class-type

79175c4

Merge branch 'dev/mandel/trampoline-name-class-type' into dev/mandel/…

df956a3

…factory-method-create-native-invocation-class

Merge branch 'main' into dev/mandel/factory-method-create-native-invo…

e917a87

…cation-class

[RGen] Generate the argument syntax for the trampoline delegate call.

f7d62f0

Add a factory method that will generate the argument syntax for the parameters to be used in the delegate call within a trampoline.

dalexsoto approved these changes May 8, 2025

View reviewed changes

Auto-format source code

58c7515

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes May 9, 2025

View reviewed changes

Base automatically changed from dev/mandel/factory-method-create-native-invocation-class to main May 9, 2025 15:05

StephaneDelcroix reviewed May 12, 2025

View reviewed changes

StephaneDelcroix approved these changes May 12, 2025

View reviewed changes

mandel-macaque and others added 2 commits May 12, 2025 11:56

Merge branch 'main' into dev/mandel/trampoline-argument-expressions

065694c

Auto-format source code

4837b53

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 291633e into main May 13, 2025
37 of 40 checks passed

mandel-macaque deleted the dev/mandel/trampoline-argument-expressions branch May 13, 2025 15:20

[RGen] Generate the argument syntax for the trampoline delegate call. #22764

[RGen] Generate the argument syntax for the trampoline delegate call. #22764

Uh oh!

Conversation

mandel-macaque commented May 8, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

StephaneDelcroix May 12, 2025

Choose a reason for hiding this comment

Uh oh!

mandel-macaque May 12, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

✅ [CI Build #4837b53] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented May 12, 2025

✅ [PR Build #4837b53] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented May 12, 2025

✅ [CI Build #4837b53] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

💻 [CI Build #4837b53] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented May 12, 2025

💻 [CI Build #4837b53] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

💻 [CI Build #4837b53] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

💻 [CI Build #4837b53] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 12, 2025

🔥 [CI Build #4837b53] Test results 🔥

Test results

Failures

❌ monotouch tests (tvOS)

❌ windows tests

Successes

Uh oh!

mandel-macaque commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects