[bgen] Don't emit/use [Preserve] attributes anymore. Fixes #19524. by rolfbjarne · Pull Request #22860 · dotnet/macios

rolfbjarne · 2025-05-21T06:34:04Z

Use [DynamicDependency] instead!

Fixes #19524.

dalexsoto · 2025-05-21T11:44:12Z

 			return;

+		if (!BindThirdPartyLibrary)
+			throw new InvalidOperationException ($"Found [Preserve] on {FormatProvider (mi)}: [Preserve] is deprecated, so don't use it.");


Maybe point to the new way of doing this here?

…some-preserve-attributes

vs-mobiletools-engineering-service2 · 2025-10-30T14:21:56Z

✅ [PR Build #168c90b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T14:28:52Z

✅ [CI Build #168c90b] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:03:16Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:07:21Z

✅ [CI Build #168c90b] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:18:16Z

💻 [CI Build #168c90b] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:26:40Z

💻 [CI Build #168c90b] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:26:47Z

💻 [CI Build #168c90b] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:28:03Z

💻 [CI Build #168c90b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T15:28:30Z

💻 [CI Build #168c90b] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

vs-mobiletools-engineering-service2 · 2025-10-30T16:07:49Z

🚀 [CI Build #168c90b] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 168c90b307711e1fd9bc5585b8886b8a6aa101bb [PR build]

[bgen] Don't emit/use [Preserve] attributes anymore. Fixes #19524.

f6062a0

Fixes #19524.

This comment has been minimized.

Sign in to view

dalexsoto reviewed May 21, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/bgen-remove-…

cc8c22a

…some-preserve-attributes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits May 22, 2025 09:38

Use different DDA overload.

be87853

Merge remote-tracking branch 'origin/main' into dev/rolf/bgen-remove-…

e0c2d78

…some-preserve-attributes

This comment has been minimized.

Sign in to view

rolfbjarne added 3 commits May 26, 2025 13:49

[dotnet-linker] Preserve a bit more.

670f60b

NSTimer fix

ac90a69

Merge remote-tracking branch 'origin/main' into dev/rolf/bgen-remove-…

1a77795

…some-preserve-attributes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits October 30, 2025 13:59

Update generated file.

88c5c63

Merge remote-tracking branch 'origin/main' into dev/rolf/bgen-remove-…

168c90b

…some-preserve-attributes

rolfbjarne marked this pull request as ready for review October 30, 2025 18:57

rolfbjarne requested a review from dalexsoto October 31, 2025 08:16

rolfbjarne enabled auto-merge (squash) October 31, 2025 08:16

dalexsoto approved these changes Oct 31, 2025

View reviewed changes

rolfbjarne merged commit 18f02dc into main Oct 31, 2025
45 checks passed

Conversation

rolfbjarne commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto May 21, 2025

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 30, 2025

✅ [PR Build #168c90b] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

✅ [CI Build #168c90b] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

✅ [CI Build #168c90b] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

💻 [CI Build #168c90b] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

💻 [CI Build #168c90b] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

💻 [CI Build #168c90b] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

💻 [CI Build #168c90b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

💻 [CI Build #168c90b] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Oct 30, 2025

🚀 [CI Build #168c90b] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

rolfbjarne commented May 21, 2025 •

edited

Loading