Skip to content

Conversation

@alexanderkyte
Copy link
Contributor

No description provided.

@dnfclas
Copy link

dnfclas commented Jul 25, 2017

@alexanderkyte,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@monojenkins
Copy link
Collaborator

Build failure

@spouliot
Copy link
Contributor

@chamons the problem with that test is that it looks like it might not fail with incorrect input.

Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be equivalent, but the change is closer to what user projects should have.

@chamons chamons merged commit ddaf288 into dotnet:master Aug 9, 2017
spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Feb 9, 2021
bump maccore for dependencies updates

New commits in xamarin/maccore:

* xamarin/maccore@c50173e637 Remove dependency on XmlDocSync repo/tools (dotnet#2392)
* xamarin/maccore@9427bd123a Update NuGet.config to enforce a single feed (dotnet#2373)
* xamarin/maccore@146b36ed00 Keychain file computed incorrectly on Big Sur (dotnet#2388) (dotnet#2390)
* xamarin/maccore@4080d06db9 [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (dotnet#2385)

Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..c50173e637f7c10066f81dd8d130035f5672611a
spouliot added a commit that referenced this pull request Feb 10, 2021
bump maccore for dependencies updates

New commits in xamarin/maccore:

* xamarin/maccore@c50173e637 Remove dependency on XmlDocSync repo/tools (#2392)
* xamarin/maccore@9427bd123a Update NuGet.config to enforce a single feed (#2373)
* xamarin/maccore@146b36ed00 Keychain file computed incorrectly on Big Sur (#2388) (#2390)
* xamarin/maccore@4080d06db9 [mlaunch] Fix dependencies for Xcode 12.5 beta 1 (#2385)

Diff: https://github.com/xamarin/maccore/compare/428964bf32f06862eb4209129c6fb5b882c3b9be..c50173e637f7c10066f81dd8d130035f5672611a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants