[runtime] Parameters passed on the stack use at least 8 bytes on x86-64. Fixes #58367. #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build success |
spouliot
suggested changes
Aug 1, 2017
Contributor
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
otherwise I ❤️ it. Let's backport to 15.4 once bots are happy with it
Member
Author
|
@spouliot I've removed the llvm bump now, I was doing too many things at the same time 😄 |
spouliot
approved these changes
Aug 1, 2017
Collaborator
|
Build success |
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Feb 9, 2021
bump maccore for dependencies updates New commits in xamarin/maccore: * xamarin/maccore@722e62d680 Remove dependency on XmlDocSync repo/tools (dotnet#2393) * xamarin/maccore@f3d1b21947 Update NuGet.config to enforce a single feed (dotnet#2374) Diff: https://github.com/xamarin/maccore/compare/77a7f937d8d54b3c7f8eb13602831205fd2a28db..722e62d68045cb7257043c5969ad31dba4038a28
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Feb 9, 2021
bump maccore for dependencies updates New commits in xamarin/maccore: * xamarin/maccore@722e62d680 Remove dependency on XmlDocSync repo/tools (dotnet#2393) * xamarin/maccore@f3d1b21947 Update NuGet.config to enforce a single feed (dotnet#2374) Diff: https://github.com/xamarin/maccore/compare/77a7f937d8d54b3c7f8eb13602831205fd2a28db..722e62d68045cb7257043c5969ad31dba4038a28
spouliot
added a commit
that referenced
this pull request
Feb 11, 2021
bump maccore for dependencies updates New commits in xamarin/maccore: * xamarin/maccore@722e62d680 Remove dependency on XmlDocSync repo/tools (#2393) * xamarin/maccore@f3d1b21947 Update NuGet.config to enforce a single feed (#2374) Diff: https://github.com/xamarin/maccore/compare/77a7f937d8d54b3c7f8eb13602831205fd2a28db..722e62d68045cb7257043c5969ad31dba4038a28 * Disable dotnet (and related tests from release branch) * [xharness] Forcefully disable .NET tests. * Exclude more .NET stuff. * Ignore dotnet (if not enabled) for tests Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
spouliot
added a commit
that referenced
this pull request
Feb 11, 2021
bump maccore for dependencies updates New commits in xamarin/maccore: * xamarin/maccore@722e62d680 Remove dependency on XmlDocSync repo/tools (#2393) * xamarin/maccore@f3d1b21947 Update NuGet.config to enforce a single feed (#2374) Diff: https://github.com/xamarin/maccore/compare/77a7f937d8d54b3c7f8eb13602831205fd2a28db..722e62d68045cb7257043c5969ad31dba4038a28 * Disable dotnet (and related tests from release branch) * [xharness] Forcefully disable .NET tests. * Exclude more .NET stuff. * Ignore dotnet (if not enabled) for tests Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.xamarin.com/show_bug.cgi?id=58367