Fix GCHandle leak in NetworkReachability.SetNotification#24146
Closed
Fix GCHandle leak in NetworkReachability.SetNotification#24146
Conversation
Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GCHandle leak in NetworkReachability.SetNotification
Fix GCHandle leak in NetworkReachability.SetNotification
Oct 31, 2025
Collaborator
✅ [CI Build #4834577] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #4834577] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
🔥 [CI Build #4834577] Build failed (Build macOS tests) 🔥Build failed for the job 'Build macOS tests' (with job status 'Failed') Pipeline on Agent |
Member
|
Closing in favor of #24147. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkReachability.SetNotificationallocates aGCHandleto keep the object alive during native callbacks but never frees it, causing a memory leak.Changes
gchAllocatedbool fieldGCHandlewhenSetNotification(null)is calledDisposeto free handle if object is disposed without explicitly removing notificationExample
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.